Hi Ludovic, Ludovic Courtès <l...@gnu.org> writes:
[...] >> Currently, we have: >> >> time make update-guix-package >> git rev-parse HEAD >> 4893a1394e2eb8b97995b491f2f37ed85513a20f >> ./pre-inst-env >> "/gnu/store/i7z4pfa0c22q0qkxyl7fy2nlp3w658yg-profile/bin/guile" >> \ >> ./build-aux/update-guix-package.scm \ >> "`git rev-parse HEAD`" >> error: Commit 4893a1394e2eb8b97995b491f2f37ed85513a20f is not pushed >> upstream. Aborting. >> make: *** [Makefile:6507: update-guix-package] Error 1 > > I agree that the better diagnostic is nice. Though it’s a script that’s > essentially for a handful of people, who can certainly cope with the > ugly error. > > Anyway, I think we didn’t analyze the initial situation well enough > (myself included, by not commenting early and accurately). I’m also not > fond of the added complexity and the risk of surprises when we make the > release, but OTOH, it’s no big deal in the big picture! I'm sorry but I don't agree with the "we didn't analyze the initial situation well enough"; if I had to think about the best way to solve this problem now, I'd still choose the way that was chosen then, as it provides the best guarantee against producing a broken Guix package, something that happened a couple times in the past, judging from git log. About complexity, I'd much rather the tool break on me than breaking 'guix pull' for everyone :-). It seems we'll have to disagree on this one; but as you said, it's a tiny part of the bigger landscape! >>> BTW, in ‘make release’ does ‘make update-guix-package’ and expects it to >>> work with a not-pushed-yet commit. So it’s a case where we need >>> GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT=yes. I want to be able to run 'make release' first to test this works correctly, but even after rebuilding my source tree from scratch (following a 'make distclean'), and also attempting 'make download-po', and following release.org from guix-maintenance, I still get: make[3]: *** No rule to make target 'po/doc/guix-manual.pot', needed by 'distdir-am'. Stop. make[3]: Leaving directory '/home/maxim/src/guix' make[2]: *** [Makefile:5521: distdir] Error 2 make[2]: Leaving directory '/home/maxim/src/guix' make[1]: *** [Makefile:5630: dist] Error 2 make[1]: Leaving directory '/home/maxim/src/guix' make: *** [Makefile:6410: dist-with-updated-version] Error 2 Can you reproduce this problem? Thank you, Maxim
