Pierre Langlois writes: > Hi Tobias, > > Tobias Geerinckx-Rice via Bug reports for GNU Guix writes: > >> Guix, >> >> ‘readmsg’ from mailutils@3.10 segfaults on aarch64, blocking >> ‘emacs’ >> and ‘emacs-no-x’, but not ‘emacs-minimal’. >> >> --- ./readmsg/tests/testsuite.dir/4/testsuite.log >> --------------------------- >> >> # -*- compilation -*- >> 4. hdr.at:17: testing readmsg -h ... >> ./hdr.at:17: >> MAIL=$abs_top_srcdir/testsuite/spool/mbox1 >> FOLDER=$MAIL >> export MAIL FOLDER >> readmsg --no-site --no-user readmsg -h SOMETHING >> --- /dev/null 2020-08-25 23:01:26.064000000 +0000 >> +++ >> /tmp/guix-build-mailutils-3.10.drv-0/mailutils-3.10/readmsg/tests/testsuite.dir/at-groups/4/stderr >> >> 2020-08- >> 27 15:25:42.447733149 +0000 >> @@ -0,0 +1 @@ >> +/tmp/guix-build-mailutils-3.10.drv-0/mailutils-3.10/readmsg/tests/testsuite.dir/at-groups/4/test-source: >> line 2 >> 1: 30506 Segmentation fault readmsg --no-site --no-user readmsg -h >> SOMETHING >> --- - 2020-08-27 15:25:42.455592145 +0000 >> +++ >> /tmp/guix-build-mailutils-3.10.drv-0/mailutils-3.10/readmsg/tests/testsuite.dir/at-groups/4/stdout >> >> 2020-08- >> 27 15:25:42.451733151 +0000 >> @@ -1,17 +1,2 @@ >> From b...@dontmailme.org Fri Dec 28 23:28:09 2001 >> -Received: (from b...@dontmailme.org) >> - by dontmailme.org id fERKR9N16790 >> - for foo...@nonexistent.net; Fri, 28 Dec 2001 22:18:08 +0200 >> -Date: Fri, 28 Dec 2001 23:28:08 +0200 >> -From: Bar <b...@dontmailme.org> >> -To: Foo Bar <foo...@nonexistent.net> >> -Message-Id: <200112232808.ferkr9n16...@dontmailme.org> >> -Subject: Re: Jabberwocky >> - >> -It seems very pretty, but it's *rather* hard to understand!' >> -Somehow it seems to fill my head with ideas -- only I don't >> -exactly know what they are! However, SOMEBODY killed SOMETHING: >> -that's clear, at any rate... >> - >> - >> >> ./hdr.at:17: exit code was 139, expected 0 >> 4. hdr.at:17: 4. readmsg -h (hdr.at:17): FAILED (hdr.at:17) > > I've been hit by this as well so I thought I'd look into it today, and I > think I found the problem! I just sent an email upstream to > bug-mailut...@gnu.org about it.
Cool, upstream fixed the bug! [0] Here's a patch to apply the fix before we get the next release. OK to commit? Thanks, Pierre [0]: https://git.savannah.gnu.org/cgit/mailutils.git/commit/?id=5ca6382fe8adb5bc436a6d873c8b86c69d5abfd1
signature.asc
Description: PGP signature
From 0aac8082acd0c19a2d991376c7527053e196a1fd Mon Sep 17 00:00:00 2001 From: Pierre Langlois <pierre.langl...@gmx.com> Date: Sun, 13 Sep 2020 13:02:52 +0100 Subject: [PATCH] gnu: mailutils: Fix unitialized variable in readmsg. Fixes mailutils on aarch64, see <https://issues.guix.gnu.org/43088>. * gnu/packages/patches/mailutils-fix-uninitialized-variable.patch: New file. * gnu/packages/mail.scm (mailutils)[source]: Add patch. * gnu/local.mk (dist_patch_DATA): Register patch. --- gnu/local.mk | 1 + gnu/packages/mail.scm | 5 +++- ...mailutils-fix-uninitialized-variable.patch | 26 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/mailutils-fix-uninitialized-variable.patch diff --git a/gnu/local.mk b/gnu/local.mk index 1baa8405c5..6cdbe0d778 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1291,6 +1291,7 @@ dist_patch_DATA = \ %D%/packages/patches/luajit-no_ldconfig.patch \ %D%/packages/patches/luit-posix.patch \ %D%/packages/patches/lvm2-static-link.patch \ + %D%/packages/patches/mailutils-fix-uninitialized-variable.patch \ %D%/packages/patches/make-impure-dirs.patch \ %D%/packages/patches/mariadb-client-test-32bit.patch \ %D%/packages/patches/mars-install.patch \ diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index 4a9c6fc90f..45d7877c27 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -197,7 +197,10 @@ example, modify the message headers or body, or encrypt or sign the message.") version ".tar.xz")) (sha256 (base32 - "17smrxjdgbbzbzakik30vj46q4iib85ksqhb82jr4vjp57akszh9")))) + "17smrxjdgbbzbzakik30vj46q4iib85ksqhb82jr4vjp57akszh9")) + (patches + ;; Fixes https://issues.guix.gnu.org/43088. + (search-patches "mailutils-fix-uninitialized-variable.patch")))) (build-system gnu-build-system) (arguments `(#:phases diff --git a/gnu/packages/patches/mailutils-fix-uninitialized-variable.patch b/gnu/packages/patches/mailutils-fix-uninitialized-variable.patch new file mode 100644 index 0000000000..2a1c81648b --- /dev/null +++ b/gnu/packages/patches/mailutils-fix-uninitialized-variable.patch @@ -0,0 +1,26 @@ +From 5ca6382fe8adb5bc436a6d873c8b86c69d5abfd1 Mon Sep 17 00:00:00 2001 +From: Sergey Poznyakoff <g...@gnu.org> +Date: Sun, 13 Sep 2020 14:43:46 +0300 +Subject: [PATCH] Fix uninitialized variable in readmsg + +* readmsg/readmsg.c (main): Initialize weedc. +--- + readmsg/readmsg.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/readmsg/readmsg.c b/readmsg/readmsg.c +index 9f305bb9c..3a9f420db 100644 +--- a/readmsg/readmsg.c ++++ b/readmsg/readmsg.c +@@ -466,7 +466,7 @@ main (int argc, char **argv) + mu_mailbox_t mbox = NULL; + struct mu_wordsplit ws; + char **weedv; +- int weedc; ++ int weedc = 0; + int unix_header = 0; + + /* Native Language Support */ +-- +2.28.0 + -- 2.28.0
