Hi Carlo, Carlo Zancanaro <ca...@zancanaro.id.au> skribis:
> When the next release of the Shepherd is made (including commit > 9ec5c0000e9a45441417a6ee4138cdcbf1b1f2b2) we should have the > capability to resolve this ticket. Woohoo! I’d like to make sure we understand the story with ‘EINTR-safe’, but after that I’m happy to push a release. > Attached is my proposed patch from the Guix side. I have tested it on > my machine by grafting the Shepherd with the appropriate patch and it > seems to work as expected. > > I tested it by changing the substitute-urls in my guix-daemon > configuration. The output of `ps aux | grep guix-daemon` after `guix > system reconfigure` showed the substitute-urls were unchanged. After > `herd restart guix-daemon` the updated substitute-urls appeared in `ps > aux | grep guix-daemon`. I did not need to reboot my system. Perfect. > One possible improvement would be to print out the services that need > to be restarted to be upgraded. Yes, that’d be nice. > From 162bd298563201ebf6eda87d46ae1b64671397da Mon Sep 17 00:00:00 2001 > From: Carlo Zancanaro <ca...@zancanaro.id.au> > Date: Sun, 26 Aug 2018 21:54:14 +1000 > Subject: [PATCH] gnu: services: Load all services on reconfigure, not just > stopped ones > > * gnu/services/shepherd.scm (shepherd-service-upgrade): Remove checks for > running services. Could you adjust the manual, where it currently says “if a service is currently running, it does not attempt to upgrade it”? Other than that LGTM! Ludo’.
