Hi Maxim, Maxim Cournoyer <maxim.courno...@gmail.com> skribis:
> Ludovic Courtès <l...@gnu.org> writes: > >> * guix/build/compile.scm: New file. >> * Makefile.am (MODULES): Add it. >> * build-aux/compile-all.scm: Use it. >> (warnings, file->module, load-module-file) >> (%default-optimizations, %lightweight-optimizations) >> (optimization-options, compile-file*): Remove. >> <top level>: Use 'compile-files'. >> * guix/build/pull.scm (%default-optimizations) >> (%lightweight-optimizations, optimization-options): Remove. >> (build-guix): Rewrite as a call to 'compile-files'. >> * guix/discovery.scm (file-name->module-name): Export. >> --- >> Makefile.am | 1 + >> build-aux/compile-all.scm | 92 ++++---------------------- >> guix/build/compile.scm | 165 >> ++++++++++++++++++++++++++++++++++++++++++++++ >> guix/build/pull.scm | 105 ++++++++--------------------- >> guix/discovery.scm | 4 +- >> 5 files changed, 209 insertions(+), 158 deletions(-) >> create mode 100644 guix/build/compile.scm > > [...] > > This and the other patches in this series look fine to me. Awesome, thanks for looking. > Maybe the change log items could be a bit more precise about what got > moved rather than removed, but given the amount of refactoring this > might be too verbose to be worth it? Well, yes to both. :-) Speaking of the “make -j” patch, on IRC Eric Bavier suggested that it didn’t work as advertised because $MAKEFLAGS didn’t contain the “-j” flag; I just checked and it does contain it here (with GNU make 4.2.1). So no problem after all? Thanks, Ludo’.
