Nikita Karetnikov <nik...@karetnikov.org> skribis:
> This patch adds a 'guix hash' command.
Nice!
> I'd like it to output non-Base32 too, but I haven't found a way to
> convert the output of 'sha256', which is a bytevector, to a string.
You mean a hexadecimal string? There’s bytevector->base16-string in
(guix utils).
> What options would you like to see implemented?
Could you copy/paste the --format option found in (guix scripts download)?
> Should we capitalize error messages?
No (info "(standards) Errors"):
The string MESSAGE should not begin with a capital letter when it
follows a program name and/or file name, because that isn't the
beginning of a sentence. (The sentence conceptually starts at the
beginning of the line.) Also, it should not end with a period.
Error messages from interactive programs, and other messages such as
usage messages, should start with a capital letter. But they should not
end with a period.
> Is it OK to output a backtrace when the specified file doesn't exist?
No, because it’s too scaring. :-)
I’m sure there are still places where the guix commands spit out a
backtrace, but we should fix that.
> + "Return the cryptographic hash of FILE in Base32."
“base32” (lower-case).
Also, could you add an entry in the manual (with a couple of sentences
explaining when users should care about this tool, and what it does), as
well as a line in po/POTFILES.in?
Thanks,
Ludo’.
