Hi Ekaitz, Ekaitz Zarraga <eka...@elenq.tech> skribis:
> This commit adds support for PEG as described in: > > <https://bford.info/pub/lang/peg.pdf> I would make this a comment below the ‘define-module’ form. > It adds support for the missing features (comments, underscores in > identifiers and escaping) while keeping the extensions (dashes in > identifiers, < and <--). > > The naming system tries to be as close as possible to the one proposed > in the paper. > > * module/ice-9/peg/string-peg.scm: Rewrite PEG parser. > * test-suite/tests/peg.test: Fix import Nice work! Questions: 1. Is the name change for lexical elements (camel case instead of lower-case + hyphens) user-visible? I guess no but better be safe than sorry. I have a preference for lower-case + hyphens out of consistency with the rest of Scheme, but I can see how keeping the same names as in the reference material helps. 2. Could you add tests for the missing features that this adds, and maybe extend ‘api-peg.texi’ accordingly too? 3. You can choose to assign copyright to the FSF or to not do that¹. In the latter case, please add a copyright line for you where appropriate. I’m really not a PEG expert though so I’d prefer more eyeballs here, but I trust your judgment. There are three (guix import *) modules that use (ice-9 peg) and that come with tests. It would be nice to check that those tests still pass with the modified string-peg.scm. Thanks! Ludo’. ¹ https://lists.gnu.org/archive/html/guile-devel/2022-10/msg00008.html
