On 10/18/18 3:56 AM, Mark H Weaver wrote: > Hi Tom, > > Tom de Vries <tdevr...@suse.de> writes: > >> On 10/16/18 3:57 AM, Mark H Weaver wrote: >>> Thanks for the report, analysis and patch. I agree with your analysis, >>> and the patch looks good. >>> >> >> If so, can the patch be committed? > > I just pushed commit c2a654b7d29f5e2f32fd1313cc80162fd0c8f992 to the > stable-2.2 branch,
Thanks! > which includes the fix from your patch (although I > used 'scm_from_utf8_string' instead of 'scm_from_latin1_string'), Right, that should give the same result on that string. > and > many other instances of the same problem. These fixes will be in the > upcoming guile-2.2.5 release. > > Does that address the problem for you? > There are two pecularities I'm affected by: - I'm not able to build from git (and I haven't found instructions listing in the README what the correct auto* invocation is). So, tarballs only. - gdb does not support guile 2.2 (so I'd need a backport of this fix to stable-2.0 branch). See also "PR21104 - 7.12.1 does not compile with latest guile (2.1.6)" ( https://sourceware.org/bugzilla/show_bug.cgi?id=21104 ). As for testing, I've done the following: - applied the patch onto the 2.2 tarball, build and ran tests, and ran hello.scm reproducer - ported the patch to the 2.0 tarball, build and ran tests, and ran hello.scm reproducer - build gdb master against the the 2.0 tarball build, ran gdb guile tests, and ran the gdb reproducer. This is as far as I can take it, and all LGTM. Thanks, - Tom > I'll leave this bug open at least until 'seed->random-state your-seed' > is fixed to support wide strings. > > Thanks again, > > Mark >
