On Wed 19 Apr 2017 18:11, Zefram <zef...@fysh.org> writes:
> Andy Wingo wrote:
>>This makes sense to me, FWIW.
>
> Patch attached.
Thank you! Applied. I adapted the change log message to follow Guile
conventions; it was:
> From 444703940983d559935c4dd2a2c89d7888c67119 Mon Sep 17 00:00:00 2001
> From: Zefram <zef...@fysh.org>
> Date: Wed, 19 Apr 2017 17:08:30 +0100
> Subject: [PATCH] correct note about Gregorian reform in SRFI-19
>
> SRFI-19 specifies proleptic use of the Gregorian calendar, so it was
> incorrect of the documentation to describe the code as erroneous in
> doing so. Rewrite the caution more neutrally, and move it to the section
> about the "date" structure, where it seems most relevant.
As applied:
Correct note about Gregorian reform in SRFI-19
* doc/ref/srfi-modules.texi (SRFI-19): SRFI-19 specifies proleptic use
of the Gregorian calendar, so it was incorrect of the documentation to
describe the code as erroneous in doing so. Rewrite the caution more
neutrally, and move it to the section about the "date" structure, where
it seems most relevant.
Note capitalization of the summary line and an inclusion of the file and
section/function in the commit message. I know the file is redundant
but this is how we currently do it. If you use Emacs and Magit,
pressing "C" (capital) in a Magit diff will add this info to the commit
log for you.
Andy
