Mea culpa.

I had an old s.tmac lying around in my home directory. Removing it
cleared the problem.

My assertion that the diagnostic is in the tarball was due to finding
it by grep, but not looking at the condition for its invocation.

The GROFF_TMAC_PATH description in troff(1) groff 1.25.0.rc4 says the
home directory is searched only in unsafe mode. Would that this were
true!

Doug


On Sun, Nov 8, 2026 at 10:41 PM G. Branden Robinson
<[email protected]> wrote:
>
> Follow-up Comment #8, bug #64438 (group groff):
>
> [comment #7 comment #7:]
> > The bug is still present in the tarball for 1.25.0.rc4
>
> Hmm, well, if that's true then it survived into 1.25.0 final.
>
> > It should be fixed in -ms, not by changing pic,
>
> I'm confused.  I didn't propose changing _pic_, and the fix (that apparently
> isn't) in 1.24.0 altered only the _ms_ macro package.
>
>
> $ git show a3deb17968d8a04cf5d2c1df34d59c198d60c4ae
> commit a3deb17968d8a04cf5d2c1df34d59c198d60c4ae
> Author: G. Branden Robinson <[email protected]>
> Date:   Mon Jul 17 19:16:56 2023 -0500
>
>     [ms]: Fix Savannah #64438.
>
>     * tmac/s.tmac (@PS): Stop treating excess arguments as erroneous,
>       foregoing preparation for pic(1) output.  Fixes regression from groff
>       1.22.4.
>
>     Fixes <https://savannah.gnu.org/bugs/?64438>.  Thanks to Doug McIlroy
>     for the report, Dave Kemper for root-cause analysis, and Deri James for
>     usability feedback.
>
> diff --git a/ChangeLog b/ChangeLog
> index 2d2073e8c..d6de099fd 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,15 @@
> +2023-07-17  G. Branden Robinson <[email protected]>
> +
> +       [ms]: Fix Savannah #64438.
> +
> +       * tmac/s.tmac (@PS): Stop treating excess arguments as
> +       erroneous, foregoing preparation for pic(1) output.  Fixes
> +       regression from groff 1.22.4.
> +
> +       Fixes <https://savannah.gnu.org/bugs/?64438>.  Thanks to Doug
> +       McIlroy for the report, Dave Kemper for root-cause analysis, and
> +       Deri James for usability feedback.
> +
>  2023-07-17  G. Branden Robinson <[email protected]>
>
>         * arch/djgpp/config.site:
> diff --git a/tmac/s.tmac b/tmac/s.tmac
> index 5fc1237eb..d3896c791 100644
> --- a/tmac/s.tmac
> +++ b/tmac/s.tmac
> @@ -2095,7 +2095,7 @@ .de PS
>  .de @PS
>  .br
>  .sp \\n[DD]u
> -.ie !\\n[.$]=2 \{\
> +.ie \\n[.$]<2 \{\
>  .      ds pic*msg .PS: expected 2 arguments, got \\n[.$]\"
>  .      as pic*msg ; not preprocessed with pic?\"
>  .      @error \\*[pic*msg]
>
>
> > because other packages may use the optional arguments. It may look as if the
> > third argument that pic passes on is the same as the second, but differences
> > may be seen when pic passes four arguments.
>
> I don't understand how _groff_ 1.24.0 failed to resolve the problem.
>
> Here's a sample input.
>
>
> $ printf '.LP\nOh,my.\n.sp\n.PS\ncircle 0.5i; move right 1.5i; circle
> 0.5i\n.PE\n.sp 3i\n.PS 3i\ncircle 0.5i\n.PE\n'
> .LP
> Oh,my.
> .sp
> .PS
> circle 0.5i; move right 1.5i; circle 0.5i
> .PE
> .sp 3i
> .PS 3i
> circle 0.5i
> .PE
>
>
> Here are the results when processing it with _groff_ 1.23.0, 1.24.0, and
> 1.25.0.
>
>
> $ printf '.LP\nOh,my.\n.sp\n.PS\ncircle 0.5i; move right 1.5i; circle
> 0.5i\n.PE\n.sp 3i\n.PS 3i\ncircle 0.5i\n.PE\n' | SOURCE_DATE_EPOCH=1000
> ~/groff-1.23.0/bin/groff -p -ms > 64438-1.23.ps
> $ printf '.LP\nOh,my.\n.sp\n.PS\ncircle 0.5i; move right 1.5i; circle
> 0.5i\n.PE\n.sp 3i\n.PS 3i\ncircle 0.5i\n.PE\n' | SOURCE_DATE_EPOCH=1000
> ~/groff-1.24.0/bin/groff -p -ms > 64438-1.24.ps
> $ printf '.LP\nOh,my.\n.sp\n.PS\ncircle 0.5i; move right 1.5i; circle
> 0.5i\n.PE\n.sp 3i\n.PS 3i\ncircle 0.5i\n.PE\n' | SOURCE_DATE_EPOCH=1000
> ~/groff-1.25.0/bin/groff -p -ms > 64438-1.25.ps
> $ diff -u 64438-1.23.ps 64438-1.24.ps
> --- 64438-1.23.ps       2026-11-08 21:26:38.776892893 -0600
> +++ 64438-1.24.ps       2026-11-08 21:26:55.728854076 -0600
> @@ -1,8 +1,8 @@
>  %!PS-Adobe-3.0
> -%%Creator: groff version 1.23.0
> -%%CreationDate: Wed Dec 31 18:16:40 1969
> +%%Creator: groff version 1.24.0
> +%%CreationDate: Thu Jan  1 00:16:40 1970
>  %%DocumentNeededResources: font Times-Roman
> -%%DocumentSuppliedResources: procset grops 1.23 0
> +%%DocumentSuppliedResources: procset grops 1.24 0
>  %%Pages: 1
>  %%PageOrder: Ascend
>  %%DocumentMedia: Default 612 792 0 () ()
> @@ -12,7 +12,7 @@
>  %%PageMedia: Default
>  %%EndDefaults
>  %%BeginProlog
> -%%BeginResource: procset grops 1.23 0
> +%%BeginResource: procset grops 1.24 0
>  %!PS-Adobe-3.0 Resource-ProcSet
>  /setpacking where{
>  pop
> @@ -262,7 +262,7 @@
>  BP
>  %%EndPageSetup
>  /F0 10/Times-Roman@0 SF(Oh,my)72 84 Q(.)-.65 E 234 132 18 DC .4 LW ST
> -378 132 18 DC ST 180 503 108 DC ST 0 Cg EP
> +378 132 18 DC ST 306 281 108 DC ST 0 Cg EP
>  %%Trailer
>  end
>  %%EOF
> $ diff -u 64438-1.24.ps 64438-1.25.ps
> --- 64438-1.24.ps       2026-11-08 21:26:55.728854076 -0600
> +++ 64438-1.25.ps       2026-11-08 21:27:04.204834668 -0600
> @@ -1,8 +1,8 @@
>  %!PS-Adobe-3.0
> -%%Creator: groff version 1.24.0
> +%%Creator: groff version 1.25.0
>  %%CreationDate: Thu Jan  1 00:16:40 1970
>  %%DocumentNeededResources: font Times-Roman
> -%%DocumentSuppliedResources: procset grops 1.24 0
> +%%DocumentSuppliedResources: procset grops 1.25 0
>  %%Pages: 1
>  %%PageOrder: Ascend
>  %%DocumentMedia: Default 612 792 0 () ()
> @@ -12,7 +12,7 @@
>  %%PageMedia: Default
>  %%EndDefaults
>  %%BeginProlog
> -%%BeginResource: procset grops 1.24 0
> +%%BeginResource: procset grops 1.25 0
>  %!PS-Adobe-3.0 Resource-ProcSet
>  /setpacking where{
>  pop
>
>
> I'm attaching screenshots of _groff_ 1.23.0 and 1.24.0 output.  As shown
> above, there is no significant difference in the generated PostScript between
> _groff_ 1.24.0 and 1.25.0.
>
> (file #59191, file #59192)
>
>     _______________________________________________________
>
> Additional Item Attachment:
>
> Name: 64438-1.23.png                 Size: 51KiB
>     <https://file.savannah.gnu.org/file/64438-1.23.png?file_id=59191>
>
> Name: 64438-1.24.png                 Size: 58KiB
>     <https://file.savannah.gnu.org/file/64438-1.24.png?file_id=59192>
>
>
>     AGPL NOTICE
>
> These attachments are served by Savane. You can download the corresponding
> source code of Savane at
> https://savannah.gnu.org/source/savane-99b9bb5c89ddd7e7187ecbf606b99ab99423d38f.tar.gz
>
>
>     _______________________________________________________
>
> To reply to this notification, you have two options:
> * In the Web UI at <https://savannah.gnu.org/bugs/?64438>.
> * By email to 347287-bugs-savannah <[email protected]>, ONLY IF you 
> preserve both
>   the 'display name' and the 'address specification' in the To: header
>   AND you sign your email with a GPG key registered in your Savannah account
>   AND you include the following line in the reply:
>
>   {savane: user = 347287; tracker = bugs; item = 64438}
>
> _______________________________________________
> Message sent via Savannah
> https://savannah.gnu.org/

Reply via email to