Update of bug #68784 (group groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #2:
commit 9c4143d3fc2d36d585274073095dc910320f43b7
Author: G. Branden Robinson <[email protected]>
Date: Fri Oct 16 17:57:44 2026 -0500
[groff]: Regression-test Savannah #68784.
* src/roff/groff/tests/error-mso-request-given-empty-argument.sh: New
file; do it.
* src/roff/groff/groff.am: Update `groff_TESTS` to run test.
Test fails at this commit.
commit 591b495132a3c759b4cb1c6e0a4a23bec40dab2f
Author: G. Branden Robinson <[email protected]>
Date: Fri Oct 16 12:57:46 2026 -0500
[troff]: Fix Savannah #68784.
* src/roff/troff/input.cpp (do_macro_source): Throw warning in category
"missing" if either the `mso` or `msoquiet` request is not given an
argument. Deduce identity of calling request handler from value of
`quietly` argument, which while at present perfectly logically coupled
to that identity, leaves me uneasy. (But in the long term I hope to
turn `msoquiet` into a macro anyway, which should be easy after
Savannah #68242 is fixed.)
Fixes <https://savannah.gnu.org/bugs/?68784>.
Before:
$ echo '.mso \*a' | groff
troff: ../src/libs/libgroff/searchpath.cpp:118: FILE*
search_path::open_file(const char*, char**): Assertion `name != 0' failed.
groff: error: troff: Aborted (core dumped)
$ echo '.msoquiet \*a' | groff
troff: ../src/libs/libgroff/searchpath.cpp:118: FILE*
search_path::open_file(const char*, char**): Assertion `name != 0' failed.
groff: error: troff: Aborted (core dumped)
After:
$ echo '.mso \*a' | ./build/test-groff -ww
troff:<standard input>:1: warning: name 'a' not defined [-w mac]
troff:<standard input>:1: warning: macro file sourcing request expects
argument [-w missing]
$ echo '.msoquiet \*a' | ./build/test-groff -ww
troff:<standard input>:1: warning: name 'a' not defined [-w mac]
troff:<standard input>:1: warning: quiet macro file sourcing request
expects argument [-w missing]
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68784>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
