Update of bug #68783 (group groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #2:
commit ebd1b9aa8cb5533e176ea11ea9e7299c82a37c47
Author: G. Branden Robinson <[email protected]>
Date: Fri Oct 16 17:10:25 2026 -0500
[groff]: Regression-test Savannah #68783.
* src/roff/groff/tests/error-so-request-given-empty-argument.sh: New
file; do it.
* src/roff/groff/groff.am: Update `groff_TESTS` to run test.
Test fails at this commit.
commit 49c7b6ce5acb56c36e607d71593b23273dc9635f
Author: G. Branden Robinson <[email protected]>
Date: Fri Oct 16 12:37:49 2026 -0500
[troff]: Fix Savannah #68783.
* src/roff/troff/input.cpp (do_source): Throw warning in category
"missing" if either the `so` or `soquiet` request is not given an
argument. Deduce identity of calling request handler from value of
`quietly` argument, which while at present perfectly logically coupled
to that identity, leaves me uneasy. (But in the long term I hope to
turn `soquiet` into a macro anyway, which should be easy after
Savannah #68242 is fixed.)
Fixes <https://savannah.gnu.org/bugs/?68783>.
Before (since groff 1.24.0):
$ echo '.so \*a' | groff
groff: error: troff: Segmentation fault (core dumped)
$ echo '.soquiet \*a' | groff
groff: error: troff: Segmentation fault (core dumped)
Now:
$ echo '.so \*a' | ./build/test-groff -ww
troff:<standard input>:1: warning: name 'a' not defined [-w mac]
troff:<standard input>:1: warning: file sourcing request expects argument
[-w missing]
$ echo '.soquiet \*a' | ./build/test-groff -ww
troff:<standard input>:1: warning: name 'a' not defined [-w mac]
troff:<standard input>:1: warning: quiet file sourcing request expects
argument [-w missing]
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68783>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
