URL:
  <https://savannah.gnu.org/bugs/?68775>

                 Summary: [PATCH] build: GROFF_G Autoconf test botched in
commit 142b8d93fc, 2026-10-08
                   Group: GNU roff
               Submitter: gbranden
               Submitted: Wed 14 Oct 2026 01:27:08 PM UTC
                Category: General
                Severity: 3 - Normal
              Item Group: Build/Installation
                  Status: In Progress
                 Privacy: Public
             Assigned to: gbranden
             Open/Closed: Open
         Discussion Lock: Unlocked
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Wed 14 Oct 2026 01:27:08 PM UTC By: G. Branden Robinson <gbranden>
[https://lists.gnu.org/archive/html/groff/2026-10/msg00017.html Alexis
(surryhill) reported an automated test failure on _groff_ 1.25.0.rc3.]

The _mm_ package's "GETST" test is the one that failed, but the reason lay
elsewhere.

I was able to reproduce the problem in an extremely stripped-down Debian
trixie chroot.

How stripped down?  No _groff_ already installed in the build environment.

That revealed that I had some bogus logic in commit 142b8d93fc.

This appears to fix it.


diff --git a/m4/groff.m4 b/m4/groff.m4
index e4b952c97..097d17a52 100644
--- a/m4/groff.m4
+++ b/m4/groff.m4
@@ -1065,14 +1065,19 @@
 AC_DEFUN([GROFF_G], [
   g=
   AC_MSG_CHECKING([for an installed groff-incompatible troff])
-  if test "`(echo .tm '|n(.g' | tr '|' '\\\\' | troff -z -i 2>&1) \
-    2>/dev/null`" = 1
+  if test -n "`command -v troff`" \
+    && test "`(echo .tm '|n(.g' | tr '|' '\\\\' | troff -z -i 2>&1) \
+      2>/dev/null`" != 1
   then
-    AC_MSG_RESULT([no])
-  else
-    AC_MSG_RESULT([yes])
     g=g
   fi
+
+  if test "$g" = "g"
+  then
+    AC_MSG_RESULT([yes])
+  else
+    AC_MSG_RESULT([no])
+  fi
   AC_SUBST([g])
 ])
 


With this patch, a build in the same stripped-down chroot passes all tests
that are attempted and expected to pass.







    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68775>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to