Follow-up Comment #24, bug #62776 (group groff):

[comment #0 original submission:]
> Alejandro Colomar requested this, and the fundamental thing is easily done.

I was right, it *is* easy!


diff --git a/doc/groff.texi.in b/doc/groff.texi.in
index 756098c2b..a1553907b 100644
--- a/doc/groff.texi.in
+++ b/doc/groff.texi.in
@@ -21530,12 +21530,11 @@
 In compatibility mode,
 ambiguous delimiters are accepted without warning.
 
-@c @item el
-@c @itemx 16
-@c @cindex @code{ie} request, and warnings
-@c @cindex @code{el} request, and warnings
-@c The @code{el} request was encountered with no prior corresponding
-@c @code{ie} request.  @xref{if-else}.
+@item style
+@itemx 16
+Input was non-idiomatic or likely to produce an unexpected result
+(or none at all),
+but is not invalid.
 
 @item scale
 @itemx 32
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 8f42d7fcf..68a691423 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -10612,6 +10612,7 @@ static struct warning_category {
   { "range", WARN_RANGE },
   { "break", WARN_BREAK },
   { "delim", WARN_DELIM },
+  { "style", WARN_STYLE },
   { "scale", WARN_SCALE },
   { "syntax", WARN_SYNTAX },
   { "tab", WARN_TAB },
@@ -10626,7 +10627,7 @@ static struct warning_category {
   { "ig", WARN_IG },
   { "color", WARN_COLOR },
   { "file", WARN_FILE },
-  { "all", WARN_MAX & ~(WARN_DI | WARN_MAC | WARN_REG) },
+  { "all", WARN_MAX & ~(WARN_STYLE | WARN_DI | WARN_MAC | WARN_REG) },
   { "w", WARN_MAX },
   { "default", DEFAULT_WARNING_CATEGORY_SET },
 };
diff --git a/doc/groff.texi.in b/doc/groff.texi.in
index 756098c2b..a1553907b 100644
--- a/doc/groff.texi.in
+++ b/doc/groff.texi.in
@@ -21530,12 +21530,11 @@
 In compatibility mode,
 ambiguous delimiters are accepted without warning.
 
-@c @item el
-@c @itemx 16
-@c @cindex @code{ie} request, and warnings
-@c @cindex @code{el} request, and warnings
-@c The @code{el} request was encountered with no prior corresponding
-@c @code{ie} request.  @xref{if-else}.
+@item style
+@itemx 16
+Input was non-idiomatic or likely to produce an unexpected result
+(or none at all),
+but is not invalid.
 
 @item scale
 @itemx 32
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 8f42d7fcf..68a691423 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -10612,6 +10612,7 @@ static struct warning_category {
   { "range", WARN_RANGE },
   { "break", WARN_BREAK },
   { "delim", WARN_DELIM },
+  { "style", WARN_STYLE },
   { "scale", WARN_SCALE },
   { "syntax", WARN_SYNTAX },
   { "tab", WARN_TAB },
@@ -10626,7 +10627,7 @@ static struct warning_category {
   { "ig", WARN_IG },
   { "color", WARN_COLOR },
   { "file", WARN_FILE },
-  { "all", WARN_MAX & ~(WARN_DI | WARN_MAC | WARN_REG) },
+  { "all", WARN_MAX & ~(WARN_STYLE | WARN_DI | WARN_MAC | WARN_REG) },
   { "w", WARN_MAX },
   { "default", DEFAULT_WARNING_CATEGORY_SET },
 };
diff --git a/src/roff/troff/troff.1.man b/src/roff/troff/troff.1.man
index eddadf32e..253737081 100644
--- a/src/roff/troff/troff.1.man
+++ b/src/roff/troff/troff.1.man
@@ -576,7 +576,7 @@ .SH Warnings
 1@2@\fIunused\fP@11@2048@tab
 2@4@break@12@4096@\fIunused\fP
 3@8@delim@13@8192@missing
-4@16@\fIunused\fP@14@16384@input
+4@16@style@14@16384@input
 5@32@scale@15@32768@escape
 6@64@range@16@65536@space
 7@128@syntax@17@131072@font
@@ -670,15 +670,6 @@ .SH Warnings
 T}
 .
 .
-.\" .TP
-.\" .BR el "\t16"
-.\" The
-.\" .B el
-.\" request was encountered with no prior corresponding
-.\" .B ie
-.\" request.
-.
-.
 .sp \n[PD]u
 escape 32768   T{
 An unsupported escape sequence was encountered.
@@ -817,6 +808,13 @@ .SH Warnings
 T}
 .
 .
+.TP
+.BR style "\t16"
+Input was non-idiomatic or likely to produce an unexpected result
+(or none at all),
+but is not invalid.
+.
+.
 .sp \n[PD]u
 syntax 128     T{
 A self-contradictory hyphenation mode or character flags were requested;
diff --git a/src/roff/troff/troff.h b/src/roff/troff/troff.h
index ac0d9c489..fd29514d8 100644
--- a/src/roff/troff/troff.h
+++ b/src/roff/troff/troff.h
@@ -54,6 +54,7 @@ enum warning_type {
   WARN_BREAK = 04,
   WARN_DELIM = 010,
   //WARN_EL = 020, // withdrawn in groff 1.24
+  WARN_STYLE = 020, // introduced in groff 1.25
   WARN_SCALE = 040,
   WARN_RANGE = 0100,
   WARN_SYNTAX = 0200,


Not applying "[PATCH]" tag because we need some logic to actually _use_ this
new warning category.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62776>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to