On Wednesday, 2 July 2025 15:27:31 BST you wrote:
> Follow-up Comment #3, bug #67268 (group groff):
> 
> 
> [comment #1 comment #1:]
> 
> > The clue is in your download file, it has 6 lines of comment at the top
> > which occurs when BuildFoundries.pl is run multiple times without an
> > intervening file removal (make clean/distclean).
> 
> [...]
> 
> > Try a 'make clean' then check font/devpdf/download has been removed, and
> > 'make -j' should then work (hopefully!). (Although Branden has recently
> > made some changes to devpdf.am I believe the above info is still true).
> I **think** I've fixed the Automake file so that the constructed
> "font/devpdf/download" won't repeatedly grow like this.
> 
> Here's what it looks like in the Git trunk, as of commit
> 
> 
> font/devpdf/download: $(devpdffontencdata) $(devpdffontmapdata) \
>   font/devpdf/DESC font/devpdf/Foundry font/devpdf/util/BuildFoundries
>         $(AM_V_GEN)$(MKDIR_P) $(top_builddir)/font/devpdf \
>         && echo "# foundry      ps-font-name    ps-font-file" >$@.tmp \
>         && echo "# A blank foundry is the default." >>$@.tmp \
>         &&

This is a bit confusing!! Why are you touching download here? We now have 
download.in so 
why not include your comments in that file - job done once.

> PATH="$(abs_top_builddir)$(GROFF_PATH_SEPARATOR)$(abs_top_builddir)/build-au
> x$(GROFF_PATH_SEPARATOR)$(PATH)" \
>              $(abs_top_builddir)/font/devpdf/util/BuildFoundries \
>                --strict $(abs_top_builddir)/font/devpdf \
>                '$(abs_top_srcdir)/font/devps:$(abs_top_builddir)/font/devps'
> \
> 
> >> $@.tmp \
> 
>         && chmod u+w $@ \
>         && mv $@.tmp $@
> 
> 
> However I see that I should get rid of the end of the "BuildFoundries"
> target, earlier in the file:
> 
> 
> MOSTLYCLEANFILES += font/devpdf/util/BuildFoundries
> font/devpdf/util/BuildFoundries: \
>   $(devpdf_srcdir)/util/BuildFoundries.pl $(SH_DEPS_SED_SCRIPT) afmtodit
>         $(AM_V_GEN)$(MKDIR_P) $(top_builddir)/font/devpdf/util \
> # ...snip...
>         && cp -f $(top_srcdir)/font/devpdf/download.in \
>                  $(top_builddir)/font/devpdf/download
This is the important bit and can replace your echo statements above, since 
this is the bit 
which populates download with Symbol-Slanted.
> 
> We shouldn't have two different rules creating "font/devpdf/download". 
> That's just asking for trouble.

Yes, its the bit I added in the commit before yours. I don't mind if it gets 
run when 
BuildFoundries is built or when it is run, but we don't want the echos.

> 
{savane: user = 90212; tracker = bugs; item = 67268}

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to