Update of bug #66439 (group groff): Status: In Progress => Fixed Open/Closed: Open => Closed Planned Release: None => 1.24.0
_______________________________________________________ Follow-up Comment #2: commit b0c3b87d3b4d569845c2a33449e2c8c9c37cbb21 Author: G. Branden Robinson <g.branden.robin...@gmail.com> Date: Mon Feb 24 23:56:36 2025 -0600 [mm]: Regression-test Savannah #66439. The bottom block feature BS/BE should work with LT letters. * contrib/mm/tests/letter-with-bottom-block-works.sh: Do it. * contrib/mm/tests/artifacts/letter_with_bottom_block: Add expected rendering. * contrib/mm/mm.am (mm_TESTS): Run test. Test fails at this commit. commit ded58835f82c659ba452d1bde638eaf5e7027247 Author: G. Branden Robinson <g.branden.robin...@gmail.com> Date: Tue Feb 25 00:10:46 2025 -0600 [mm]: Fix Savannah #66439 (BS/BE with LT). * contrib/mm/m.tmac (BS, BE): Use box diversion instead of a regular one to populate the bottom block. This fixes interaction of the bottom block feature--when `BS` and `BE` are called prior to formatting any other text--with `LT` letters specifically but might also resolve other similar problems with BS/BE use. Using a regular diversion moved the vertical drawing position from its "pre-page" location of "-1" (because the `BS` macro called `br` to ensure that the bottom block didn't absorb any partially collected line). That in turn sprung the default header trap that writes a centered page number. The `LT` macro is written such that if the drawing position is not at the top of the page, it fails to format the pre-body letter material (writer's address, date, inside address, salutation, etc.). (Because the first page has already started and the drawing position was non-negative, the `LT` macro was also too late to turn off the default header on the first page.) (BE): Annotate explicit `br` retained here; we don't want to silently discard a partially collected line when closing the box diversion. The document author should delete from a bottom block any undesired content on a partially collected line. Fixes <https://savannah.gnu.org/bugs/?66439>. Thanks to Oliver Corff for prompting detection of this bug. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?66439> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
signature.asc
Description: PGP signature