Follow-up Comment #1, bug #66479 (group groff):

At 2024-11-23T11:00:03-0500, Sven Schober wrote:
> Date: Sat 23 Nov 2024 03:59:59 PM UTC By: Sven Schober <sschober>
> It's me again, your (hopefully) friendly macos build tester. :)
>
> Today, and on the latest HEAD (2562cf237), I found 5 failing tests on
> macos.  I've attached the test-suite.log, but here is the gist:

Thanks!  I appreciate the portability testing.

> rg '^FAIL:' test-suite.log.2562cf237
> 17:FAIL: contrib/hdtbl/examples/test-hdtbl.sh
> 26:FAIL: src/roff/groff/tests/dvi-device-smoke-test.sh
> 39:FAIL: tmac/tests/an_vertical-margins-are-correct.sh
> 116:FAIL: tmac/tests/doc-old_vertical-margins-are-correct.sh
> 193:FAIL: tmac/tests/doc_vertical-margins-are-correct.sh
>
> It seems as though whitespace is a problem in my environment, where it
> isn't elsewhere.
>
> I fixed the tests for me, by using `tr` to strip away spaces. I hope
> this portable to other environments - I saw `tr` usage in other
> places/tests.
>
> My patch for the failing tests is attached as well.

It probably _is_ portable, but I'd prefer to solve the problem a
slightly different way.

For four of the five cases I can see what to do.

For the fifth, would you alter the test script as follows and put the
results in this ticket?

src/roff/groff/tests/dvi-device-smoke-test.sh

Before:


printf ".ft JPM\n$jstr" | "$groff" -Kutf8 -Tdvi | od -tx1 \
   | grep -q '81 30 55 81 30 56 81 6c e2' || wail


Add:


printf ".ft JPM\n$jstr" | "$groff" -Kutf8 -Tdvi | od -tx1


In other words, I want to see exactly what's going on with the `od`
output.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66479>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to