Follow-up Comment #12, bug#64772 (group groff):
[comment #9 comment #9:]
> I will have a shot at this.
Thanks for volunteering!
> The current difference between my branch
> and that of master is in the attachments.
>
> Most of it is an addition to the bugs #54538, #54539,
> #55007, #55027, #55044, and #55732.
All those as clickable links: bug #54538, bug #54539, bug #55007, bug #55027,
bug #55044, and bug #55732
Some of these bug reports have patches that have been reviewed by other
developers, but it is not clear this feedback has been taken into account.
Bug #55044, for example, has an extensive analysis of what is wrong with its
proposed patch, but that patch appears to have been applied as-is in the
hdtbl.tmac.diff attachment here.
In any case, it seems unlikely a monolithic patch of the sort in the
hdtbl.tmac.diff attachment will be accepted; more useful are individual
changes with a log entry explaining each one's rationale.
To that end, my advice would be to focus on the individual bug reports cited
above. Address the feedback provided, either by refining the patch or
refuting points made against it, until you have something that solves the
identified problem in a manner acceptable to everyone. Through this process
you'll learn how to better get patches accepted -- whether this is by creating
better patches, or better justifying them.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?64772>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
