URL:
<https://savannah.gnu.org/bugs/?64986>
Summary: [PATCH] add .em1 request
Group: GNU roff
Submitter: barx
Submitted: Tue 05 Dec 2023 02:51:27 PM CST
Category: Core
Severity: 1 - Wish
Item Group: Feature change
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release: None
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: Tue 05 Dec 2023 02:51:27 PM CST By: Dave <barx>
These threads (actually one thread, but the archiver split it up)
* http://lists.gnu.org/r/groff/2009-04/msg00019.html
* http://lists.gnu.org/r/groff/2009-04/msg00020.html
explain a limitation of the .em request and introduce a new request, .em1,
that doesn't have this limitation.
The thread ended with Werner's patch and call for testing, so perhaps the
patch was never committed because no one followed up.
However, the patch only adds a new request, and doesn't affect the behavior of
any existing ones, so the risk of regression is low even if the new request
does have bugs. We also have a robust testing framework now to catch
regressions, something lacking in 2009.
The code has changed too much since 2009 for the patch to apply as-was, so I
generated a new patch that applies to the current
[http://git.savannah.gnu.org/cgit/groff.git/tree/src/roff/troff/input.cpp
src/roff/troff/input.cpp]. I kept Werner's constructs even in places I might
have refactored things, but tweaked his names to match the code's current
nomenclature (e.g. "eoi_macro1" in place of his "end_macro1", since the extant
"end_macro" has been since renamed "eoi_macro").
The patch doesn't update any documentation to cover the new request. The
person likeliest to apply the patch will have his own ideas about how to best
document it. But I'm willing to tackle this instead if he'd rather delegate
that.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Tue 05 Dec 2023 02:51:27 PM CST Name: em1.revised.patch Size: 2KiB
By: barx
Werner's .em1 patch, revised to apply to current code
<http://savannah.gnu.org/bugs/download.php?file_id=55408>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?64986>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
