Update of bug #64651 (project groff):
Status: None => Invalid
Assigned to: None => gbranden
Open/Closed: Open => Closed
Summary: [troff] wrong indent in "input.cpp" => [bjarnigroff]
wrong indent in "input.cpp"
_______________________________________________________
Follow-up Comment #1:
This report makes very little sense with respect to _groff_ 1.23.0.
1. Indentation problems are a minor issue that do not rise to the level of
Savannah bug reports, especially if they do not provoke compiler warnings for
being misleading, and ordinarily they do not even warrant change logging.
See [https://git.savannah.gnu.org/cgit/groff.git/tree/HACKING?h=1.23.0#n53 our
HACKING file].
Changes should of course be documented in the Git commit message.
If a change alters only comments or formatting of source code, or
makes editorial changes to documentation, and does not resolve a
Savannah ticket, you can stop at that.
2. The quoted diff does not alter indentation, but adds code.
3. The quoted diff is syntactically invalid; there is no line number
information for the "hunk" suggesting where in the file it would apply.
4. The quoted diff resembles, but is not, Git diff output. Namely, the
identity of the committer has been effaced. Git-style diffs intended as
patches to be applied against GNU _roff_ source code should identify who
authored the change.
5. The quoted diff would not apply even if all of the above defects were
addressed, because it does not correspond to code in the current and supported
_groff_ release. It appears to be an attempted patch to the `open_mac_file`
function. A glance at this function's source code in _groff_ 1.23.0 reveals
the inapplicability of the patch.
https://git.savannah.gnu.org/cgit/groff.git/tree/src/roff/troff/input.cpp?h=1.23.0#n7816
static FILE *open_mac_file(const char *mac, char **path)
{
// Try `mac`.tmac first, then tmac.`mac`. Expect ENOENT errors.
char *s1 = new char[strlen(mac)+strlen(MACRO_POSTFIX)+1];
strcpy(s1, mac);
strcat(s1, MACRO_POSTFIX);
FILE *fp = mac_path->open_file(s1, path);
if (!fp && ENOENT != errno)
error("can't open macro file '%1': %2", s1, strerror(errno));
delete[] s1;
if (!fp) {
char *s2 = new char[strlen(mac)+strlen(MACRO_PREFIX)+1];
strcpy(s2, MACRO_PREFIX);
strcat(s2, mac);
fp = mac_path->open_file(s2, path);
if (!fp && ENOENT != errno)
error("can't open macro file '%1': %2", s2, strerror(errno));
delete[] s2;
}
return fp;
}
If one has difficulty spotting the problem, look for `a_delete`.
[https://git.savannah.gnu.org/cgit/groff.git/commit/?id=61d2307000c457db0604a7833e29ca4ad15884f7
Commit 61d2307000 from August 2021 might be instructive.]
I suggest that, [https://savannah.gnu.org/bugs/?64509 as has happened before],
you are reporting to the GNU project a defect that is unique to your private
fork of _groff_.
This project's developers have asked you multiple times to report defects only
against the code that we develop, publish, and support. If you need
assistance developing your private implementation of a *roff, the _groff_
mailing list is a more appropriate forum than the GNU Savannah ticket
tracker.
Closing as invalid.
[comment #0 original submission:]
> Subject: [troff] wrong indent in "input.cpp"
>
> Directory "src/roff/troff".
>
> commit 4258aad04d28079fe4d317b8081e7ad9ae8420e6
> Date: Mon Feb 1 17:36:52 2021 +1100
>
> if (!fp) {
> char *s2 = new char[strlen(mac)+strlen(MACRO_PREFIX)+1];
> strcpy(s2, MACRO_PREFIX);
> strcat(s2, mac);
> fp = mac_path->open_file(s2, path);
> + if (!fp && ENOENT != errno)
> + error("can't open macro file '%1': %2", s2, strerror(errno));
> a_delete s2;
> }
>
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?64651>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
