On 5/29/22 08:40, Jim Meyering wrote:
Adding a test for the new behavior would be nice.
OK, thanks, I installed the new warning and followed up with the
attached patch to test it.From d85711f6945f79443bbb51b4d0f668a91a163e50 Mon Sep 17 00:00:00 2001
From: Paul Eggert <egg...@cs.ucla.edu>
Date: Sun, 29 May 2022 16:41:50 -0700
Subject: [PATCH] tests: new test color-colors
* tests/Makefile.am (TESTS): Add it.
* tests/color-colors: New file.
---
tests/Makefile.am | 1 +
tests/color-colors | 48 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 49 insertions(+)
create mode 100755 tests/color-colors
diff --git a/tests/Makefile.am b/tests/Makefile.am
index d72637f..e39c84e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -84,6 +84,7 @@ TESTS = \
char-class-multibyte \
char-class-multibyte2 \
context-0 \
+ color-colors \
count-newline \
dfa-coverage \
dfa-heap-overrun \
diff --git a/tests/color-colors b/tests/color-colors
new file mode 100755
index 0000000..3998277
--- /dev/null
+++ b/tests/color-colors
@@ -0,0 +1,48 @@
+#!/bin/sh
+# Check that GREP_COLOR elicits a warning.
+
+# Copyright 2022 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+
+fail=0
+unset GREP_COLORS
+unset GREP_COLOR
+LC_ALL=C
+export LC_ALL
+
+printf 'x\n\n' >in || framework_failure_
+printf '%s\n' \
+ "grep: warning: GREP_COLOR='36' is deprecated; use GREP_COLORS='mt=36'" \
+ >exp.err || framework_failure_
+
+GREP_COLORS='mt=36:ln=35' grep --color=always . in >exp 2>err || fail=1
+compare /dev/null err || fail=1
+GREP_COLOR='36' GREP_COLORS='ln=35' grep --color=always . in >out 2>err \
+ || fail=1
+compare exp out || fail=1
+compare exp.err err || fail=1
+
+GREP_COLORS='mt=36' grep --color=always . in >exp 2>err || fail=1
+compare /dev/null err || fail=1
+GREP_COLOR='36' grep --color=always . in >out 2>err || fail=1
+compare exp out || fail=1
+compare exp.err err || fail=1
+
+GREP_COLORS='ln=35' grep --color=always . in >out 2>err || fail=1
+compare /dev/null err || fail=1
+
+Exit $fail
--
2.34.1
