On Sun, Jan 20, 2019 at 10:03 AM Paul Eggert <egg...@cs.ucla.edu> wrote: > Jim Meyering wrote: > > Technically, we could fix it by adding more ifdefs, but I think it > > would not be worthwhile to accommodate this use case. > > I looked into this and discovered that fixing this can actually simplify the > source code by removing the need for the "We can't get here" glitch in > pcresearch.c. Although the fix does add complexity elsewhere so that the total > number of ifdefs and ifs remains the same, overall grep gets a bit simpler and > cleaner with the fix so I took the liberty of installing it (attached).
Nice. Thanks for taking the time to move-"up" and reduce the complexity.
