On 12/16/2014 04:42 AM, Norihiro Tanaka wrote:
Thanks for the review and suggestion. If using_utf8 () is true, we can
set always_character_boundary to true except 0x80-0xbf.
Even better, thanks.
>This won't assign anything to *WCP, contrary to the documented API for
>for skip_remains_mb. This is OK (as callers don't care) but the API
>documentation should be changed to reflect the actual behavior.
Oh! if WCP is needed, we must be go through step by step, as a wide
character before P is set to *WCP. I fixed it and updated the API
documentation.
This part of the patch does too much work, as the caller inspects *WCP
only when skip_remains_mb returns a value not equal to p. So there's no
need for the "wcp == NULL &&" test in the patch. Instead, the documented
API can change, saying that *WCP is assigned to only if WCP is non-NULL
and the result is greater than p.
