Stefano Lattarini wrote: > On Friday 14 October 2011, Jim Meyering wrote: >> Stefano Lattarini wrote: >> > * Makefile.am (run-syntax-check): Fix logic, to ensure that >> > the recipe of this target returns a non-zero exit status if >> > "make syntax-check" fails. >> >> Good catch. Applied. >> > Thanks. But now that I think about it, I see that we could improve > the rule even more, by making it work in VPATH builds too; i.e., from: > > $(AM_V_GEN)test ! -d .git || $(MAKE) syntax-check > > to: > > $(AM_V_GEN)test ! -d $(top_srcdir)/.git || $(MAKE) syntax-check > > Of course, this makes sense only if the syntax checks themselves work > in VPATH builds ...
Hi Stefano, Thanks. However, I run the syntax-checks solely from srcdir builds. For me at least, imposing the VPATH regimen for that rule is an added maintenance burden (and slight obfuscation) that brings little to no benefit.
