On Sun, Sep 12, 2010 at 10:46, Jim Meyering <[email protected]> wrote: > That patch induces a performance *decrease* on at least one system. > > Built using --without-included-regex > Run on an idle i920 @ 2.67GHz, kernel 2.6.18-194.11.3.el5PAE, i686: > > yes 1234567890123456789012345678901234567890123456789012567890 |sed 100000q > > in > for i in $(seq 10); do env time --f=%E env LC_ALL=fr_FR.UTF8 \ > ./grep '[a-z]' in;done
With a cs_CZ.UTF-8 locale, however the unpatched grep would likely fail to match for example ^[a-z]$ against "ch", which is also a correctness issue. Regarding the failing test-case, the lack of equivalence class support is in glibc. Should I commit the patch without the testcase? Paolo
