* On Monday 2005-07-04 at 20:11:25 +0100, Julian Foad wrote: > Charles, thanks for all the work you're doing, getting things moving again, > fixing bugs, preparing the way for future improvements, and adding some > oft-requested enhancements.
My pleasure. I may explain a little bit how those last proposed patches came about. We have at least one known bug in src/kwset.c, and I didn't understand this file enough to be able to assess the correctness of the proposed patch (or of its equivalent variants). So I set out to understand the file, something I've been wanting to do for a few weeks now. In the course of doing this, I inevitably noticed some stuff. This explains the patches, but my first goal was indeed to give myself the ability to fix the bug(s) in it. I'm pretty sure the fix for the unsigned char overflow is correct, but I'm not sure that the current tests are the tightest limit cases.