Hi Luca, > > > Should we include a (standalone) copy of it in Gnulib? > > > The included one is for one of the > additional macros that you don't need, so you can omit it (I'll fix it > anyway at the source to avoid this issue even for the other macro).
Thanks for having fixed this so quickly. > I had already mentioned here > https://github.com/coreutils/coreutils/pull/317#issuecomment-4944632425 > that I can send a patch for gnulib so that all of this is done in one > place, if you wish. Do you want me to do that? We don't read GitHub normally. But yes, a patch that introduces a Gnulib module for <sd-dlopen.h> would be welcome. Some modification would be needed for portability, though (either in this .h file or in some Gnulib-specific wrapper): - The definitions should be only active #if defined __ELF__ since on non-ELF system (think of macOS and Windows) a binary file does not have arbitrary sections. - Also, they should only be active #if defined __GNUC__ || defined __clang__ since these are the only compilers which support __asm__. - And then, a test whether the pseudo-ops .ifndef .endif .balign are supported. Can this be done without an Autoconf test? Just by inspecting the preprocessor symbols? The platform to test here is Solaris, of course, which does not use the GNU assembler by default. Bruno
