These three syntax-check rules fail:
$ make sc_maint
make -s srcdir=. gnulib_dir=. _build-aux=build-aux \
-f cfg.mk -f maint.mk syntax-check
make[1]: *** No rule to make target 'syntax-check'. Stop.
make: *** [Makefile:79: sc_maint] Error 2
Seeing that cfg.mk has not been changed in 9 years, this means
this rule is unmaintained.
$ make sc_cpp_indent_check
cppi: lib/canonicalize.c: line 64: not properly indented
cppi: lib/canonicalize.c: line 66: not properly indented
cppi: lib/canonicalize.c: line 69: not properly indented
cppi: lib/careadlinkat.c: line 175: not properly indented
cppi: lib/careadlinkat.c: line 176: not properly indented
cppi: lib/careadlinkat.c: line 177: not properly indented
cppi: lib/careadlinkat.c: line 178: not properly indented
cppi: lib/fcntl.c: line 261: not properly indented
cppi: lib/fcntl.c: line 263: not properly indented
cppi: lib/fcntl.c: line 264: not properly indented
cppi: lib/fcntl.c: line 266: not properly indented
cppi: lib/fcntl.c: line 267: not properly indented
cppi: lib/fcntl.c: line 269: not properly indented
cppi: lib/fcntl.c: line 270: not properly indented
cppi: lib/fcntl.c: line 272: not properly indented
cppi: lib/fcntl.c: line 273: not properly indented
cppi: lib/fcntl.c: line 275: not properly indented
cppi: lib/fcntl.c: line 276: not properly indented
cppi: lib/fcntl.c: line 278: not properly indented
cppi: lib/fcntl.c: line 279: not properly indented
cppi: lib/fcntl.c: line 281: not properly indented
cppi: lib/fcntl.c: line 282: not properly indented
cppi: lib/fcntl.c: line 284: not properly indented
cppi: lib/fcntl.c: line 285: not properly indented
cppi: lib/fcntl.c: line 287: not properly indented
cppi: lib/fcntl.c: line 288: not properly indented
cppi: lib/fcntl.c: line 290: not properly indented
cppi: lib/fcntl.c: line 291: not properly indented
cppi: lib/fcntl.c: line 293: not properly indented
cppi: lib/fcntl.c: line 294: not properly indented
cppi: lib/fcntl.c: line 296: not properly indented
cppi: lib/fcntl.c: line 297: not properly indented
cppi: lib/fcntl.c: line 299: not properly indented
cppi: lib/fcntl.c: line 300: not properly indented
cppi: lib/fcntl.c: line 302: not properly indented
cppi: lib/fcntl.c: line 303: not properly indented
cppi: lib/fcntl.c: line 305: not properly indented
cppi: lib/fcntl.c: line 306: not properly indented
cppi: lib/fcntl.c: line 308: not properly indented
cppi: lib/fcntl.c: line 309: not properly indented
cppi: lib/fcntl.c: line 311: not properly indented
cppi: lib/fcntl.c: line 312: not properly indented
cppi: lib/fcntl.c: line 314: not properly indented
cppi: lib/fcntl.c: line 315: not properly indented
cppi: lib/fcntl.c: line 317: not properly indented
cppi: lib/fcntl.c: line 318: not properly indented
cppi: lib/fcntl.c: line 320: not properly indented
cppi: lib/fcntl.c: line 321: not properly indented
cppi: lib/fcntl.c: line 323: not properly indented
cppi: lib/fcntl.c: line 324: not properly indented
cppi: lib/fcntl.c: line 326: not properly indented
cppi: lib/fcntl.c: line 331: not properly indented
cppi: lib/fcntl.c: line 333: not properly indented
cppi: lib/fcntl.c: line 334: not properly indented
cppi: lib/fcntl.c: line 336: not properly indented
cppi: lib/fcntl.c: line 337: not properly indented
cppi: lib/fcntl.c: line 339: not properly indented
cppi: lib/fcntl.c: line 340: not properly indented
cppi: lib/fcntl.c: line 342: not properly indented
cppi: lib/fcntl.c: line 343: not properly indented
cppi: lib/fcntl.c: line 345: not properly indented
cppi: lib/fcntl.c: line 346: not properly indented
cppi: lib/fcntl.c: line 348: not properly indented
cppi: lib/fcntl.c: line 349: not properly indented
cppi: lib/fcntl.c: line 351: not properly indented
cppi: lib/fcntl.c: line 352: not properly indented
cppi: lib/fcntl.c: line 354: not properly indented
cppi: lib/fcntl.c: line 355: not properly indented
cppi: lib/fcntl.c: line 357: not properly indented
cppi: lib/fcntl.c: line 358: not properly indented
cppi: lib/fcntl.c: line 360: not properly indented
cppi: lib/fcntl.c: line 361: not properly indented
cppi: lib/fcntl.c: line 363: not properly indented
cppi: lib/fcntl.c: line 364: not properly indented
cppi: lib/fcntl.c: line 366: not properly indented
cppi: lib/fcntl.c: line 367: not properly indented
cppi: lib/fcntl.c: line 369: not properly indented
cppi: lib/fcntl.c: line 370: not properly indented
cppi: lib/fcntl.c: line 372: not properly indented
cppi: lib/fcntl.c: line 373: not properly indented
cppi: lib/fcntl.c: line 375: not properly indented
cppi: lib/fcntl.c: line 376: not properly indented
cppi: lib/fcntl.c: line 378: not properly indented
cppi: lib/fcntl.c: line 379: not properly indented
cppi: lib/fcntl.c: line 381: not properly indented
cppi: lib/fcntl.c: line 382: not properly indented
cppi: lib/fcntl.c: line 384: not properly indented
cppi: lib/fcntl.c: line 385: not properly indented
cppi: lib/fcntl.c: line 387: not properly indented
cppi: lib/fcntl.c: line 388: not properly indented
cppi: lib/fcntl.c: line 390: not properly indented
cppi: lib/fcntl.c: line 391: not properly indented
cppi: lib/fcntl.c: line 393: not properly indented
cppi: lib/fcntl.c: line 394: not properly indented
cppi: lib/fcntl.c: line 396: not properly indented
cppi: lib/fcntl.c: line 397: not properly indented
cppi: lib/fcntl.c: line 399: not properly indented
cppi: lib/fcntl.c: line 400: not properly indented
cppi: lib/fcntl.c: line 402: not properly indented
cppi: lib/fcntl.c: line 403: not properly indented
cppi: lib/fcntl.c: line 405: not properly indented
cppi: lib/fcntl.c: line 406: not properly indented
cppi: lib/fcntl.c: line 408: not properly indented
cppi: lib/fcntl.c: line 409: not properly indented
cppi: lib/fcntl.c: line 411: not properly indented
cppi: lib/fcntl.c: line 412: not properly indented
cppi: lib/fcntl.c: line 414: not properly indented
cppi: lib/fcntl.c: line 415: not properly indented
cppi: lib/fcntl.c: line 417: not properly indented
cppi: lib/fcntl.c: line 418: not properly indented
cppi: lib/fcntl.c: line 420: not properly indented
cppi: lib/fsusage.c: line 34: not properly indented
cppi: lib/fsusage.c: line 35: not properly indented
cppi: lib/fsusage.c: line 36: not properly indented
cppi: lib/fsusage.c: line 37: not properly indented
cppi: lib/fsusage.c: line 38: not properly indented
cppi: lib/fsusage.c: line 39: not properly indented
cppi: lib/fsusage.c: line 40: not properly indented
cppi: lib/fsusage.c: line 41: not properly indented
cppi: lib/fsusage.c: line 42: not properly indented
cppi: lib/fts.c: line 1645: not properly indented
cppi: lib/md5.c: line 178: not properly indented
cppi: lib/md5.c: line 179: not properly indented
cppi: lib/md5.c: line 188: not properly indented
cppi: lib/md5.c: line 220: not properly indented
cppi: lib/md5.c: line 221: not properly indented
cppi: lib/md5.c: line 222: not properly indented
cppi: lib/md5.c: line 223: not properly indented
cppi: lib/md5.c: line 264: not properly indented
cppi: lib/md5.c: line 276: not properly indented
cppi: lib/md5.c: line 309: not properly indented
cppi: lib/md5.c: line 310: not properly indented
cppi: lib/mkfifoat.c: line 34: not properly indented
cppi: lib/mknodat.c: line 34: not properly indented
cppi: lib/mktime.c: line 256: not properly indented
cppi: lib/mktime.c: line 269: not properly indented
cppi: lib/mktime.c: line 270: not properly indented
cppi: lib/mktime.c: line 341: not properly indented
cppi: lib/mktime.c: line 347: not properly indented
cppi: lib/openat.c: line 111: not properly indented
cppi: lib/openat.c: line 113: not properly indented
cppi: lib/openat.c: line 115: not properly indented
cppi: lib/readutmp.c: line 316: not properly indented
cppi: lib/readutmp.c: line 317: not properly indented
cppi: lib/readutmp.c: line 319: not properly indented
cppi: lib/readutmp.c: line 320: not properly indented
cppi: lib/readutmp.c: line 362: not properly indented
cppi: lib/readutmp.c: line 364: not properly indented
cppi: lib/readutmp.c: line 366: not properly indented
cppi: lib/readutmp.c: line 370: not properly indented
cppi: lib/readutmp.c: line 372: not properly indented
cppi: lib/readutmp.c: line 374: not properly indented
cppi: lib/readutmp.c: line 376: not properly indented
cppi: lib/readutmp.c: line 378: not properly indented
cppi: lib/readutmp.c: line 380: not properly indented
cppi: lib/readutmp.c: line 381: not properly indented
cppi: lib/readutmp.c: line 383: not properly indented
cppi: lib/readutmp.c: line 385: not properly indented
cppi: lib/readutmp.c: line 386: not properly indented
cppi: lib/readutmp.c: line 388: not properly indented
cppi: lib/readutmp.c: line 390: not properly indented
cppi: lib/readutmp.c: line 392: not properly indented
cppi: lib/readutmp.c: line 394: not properly indented
cppi: lib/readutmp.c: line 396: not properly indented
cppi: lib/readutmp.c: line 516: not properly indented
cppi: lib/readutmp.c: line 518: not properly indented
cppi: lib/readutmp.c: line 520: not properly indented
cppi: lib/readutmp.c: line 522: not properly indented
cppi: lib/readutmp.c: line 524: not properly indented
cppi: lib/readutmp.c: line 526: not properly indented
cppi: lib/readutmp.c: line 527: not properly indented
cppi: lib/readutmp.c: line 529: not properly indented
cppi: lib/readutmp.c: line 531: not properly indented
cppi: lib/readutmp.c: line 532: not properly indented
cppi: lib/readutmp.c: line 534: not properly indented
cppi: lib/readutmp.c: line 536: not properly indented
cppi: lib/readutmp.c: line 537: not properly indented
cppi: lib/readutmp.c: line 539: not properly indented
cppi: lib/readutmp.c: line 541: not properly indented
cppi: lib/readutmp.c: line 542: not properly indented
cppi: lib/readutmp.c: line 544: not properly indented
cppi: lib/readutmp.c: line 546: not properly indented
cppi: lib/renameatu.c: line 153: not properly indented
cppi: lib/renameatu.c: line 155: not properly indented
cppi: lib/savewd.c: line 69: not properly indented
cppi: lib/savewd.c: line 71: not properly indented
cppi: lib/savewd.c: line 73: not properly indented
cppi: lib/set-permissions.c: line 34: not properly indented
cppi: lib/set-permissions.c: line 36: not properly indented
cppi: lib/set-permissions.c: line 38: not properly indented
cppi: lib/sha1.c: line 166: not properly indented
cppi: lib/sha1.c: line 167: not properly indented
cppi: lib/sha1.c: line 176: not properly indented
cppi: lib/sha1.c: line 206: not properly indented
cppi: lib/sha1.c: line 207: not properly indented
cppi: lib/sha1.c: line 208: not properly indented
cppi: lib/sha1.c: line 209: not properly indented
cppi: lib/sha1.c: line 212: not properly indented
cppi: lib/sha1.c: line 213: not properly indented
cppi: lib/sha1.c: line 214: not properly indented
cppi: lib/sha1.c: line 215: not properly indented
cppi: lib/sha1.c: line 241: not properly indented
cppi: lib/sha1.c: line 243: not properly indented
cppi: lib/sha1.c: line 247: not properly indented
cppi: lib/sha256.c: line 228: not properly indented
cppi: lib/sha256.c: line 229: not properly indented
cppi: lib/sha256.c: line 238: not properly indented
cppi: lib/sha256.c: line 268: not properly indented
cppi: lib/sha256.c: line 289: not properly indented
cppi: lib/sha256.c: line 290: not properly indented
cppi: lib/sha256.c: line 319: not properly indented
cppi: lib/sha256.c: line 320: not properly indented
cppi: lib/sha256.c: line 321: not properly indented
cppi: lib/sha256.c: line 322: not properly indented
cppi: lib/sha256.c: line 323: not properly indented
cppi: lib/sha256.c: line 325: not properly indented
cppi: lib/sha256.c: line 329: not properly indented
cppi: lib/sha512.c: line 229: not properly indented
cppi: lib/sha512.c: line 230: not properly indented
cppi: lib/sha512.c: line 239: not properly indented
cppi: lib/sha512.c: line 269: not properly indented
cppi: lib/sha512.c: line 314: not properly indented
cppi: lib/sha512.c: line 315: not properly indented
cppi: lib/sha512.c: line 345: not properly indented
cppi: lib/sha512.c: line 346: not properly indented
cppi: lib/sha512.c: line 347: not properly indented
cppi: lib/sha512.c: line 348: not properly indented
cppi: lib/sha512.c: line 350: not properly indented
cppi: lib/sha512.c: line 356: not properly indented
cppi: lib/stat.c: line 361: not properly indented
cppi: lib/stat.c: line 363: not properly indented
cppi: lib/stat-w32.c: line 26: not properly indented
cppi: lib/stat-w32.c: line 27: not properly indented
cppi: lib/stat-w32.c: line 28: not properly indented
cppi: lib/stat-w32.c: line 29: not properly indented
cppi: lib/stat-w32.c: line 30: not properly indented
cppi: lib/stat-w32.c: line 31: not properly indented
cppi: lib/stat-w32.c: line 32: not properly indented
cppi: lib/stat-w32.c: line 33: not properly indented
cppi: lib/stat-w32.c: line 34: not properly indented
cppi: lib/stat-w32.c: line 35: not properly indented
cppi: lib/stat-w32.c: line 36: not properly indented
cppi: lib/stat-w32.c: line 37: not properly indented
cppi: lib/stat-w32.c: line 38: not properly indented
cppi: lib/stat-w32.c: line 39: not properly indented
cppi: lib/stat-w32.c: line 41: not properly indented
cppi: lib/stat-w32.c: line 42: not properly indented
cppi: lib/stat-w32.c: line 43: not properly indented
cppi: lib/stat-w32.c: line 44: not properly indented
cppi: lib/stat-w32.c: line 45: not properly indented
cppi: lib/stat-w32.c: line 46: not properly indented
cppi: lib/stat-w32.c: line 47: not properly indented
cppi: lib/stat-w32.c: line 50: not properly indented
cppi: lib/stat-w32.c: line 52: not properly indented
cppi: lib/stat-w32.c: line 55: not properly indented
cppi: lib/stat-w32.c: line 56: not properly indented
cppi: lib/stat-w32.c: line 57: not properly indented
cppi: lib/stat-w32.c: line 58: not properly indented
cppi: lib/stat-w32.c: line 61: not properly indented
cppi: lib/stat-w32.c: line 62: not properly indented
cppi: lib/stat-w32.c: line 63: not properly indented
cppi: lib/stat-w32.c: line 65: not properly indented
cppi: lib/stat-w32.c: line 68: not properly indented
cppi: lib/stat-w32.c: line 71: not properly indented
cppi: lib/stat-w32.c: line 78: not properly indented
cppi: lib/stat-w32.c: line 93: not properly indented
cppi: lib/stat-w32.c: line 96: not properly indented
cppi: lib/stat-w32.c: line 103: not properly indented
cppi: lib/stat-w32.c: line 105: not properly indented
cppi: lib/stat-w32.c: line 106: not properly indented
cppi: lib/stat-w32.c: line 108: not properly indented
cppi: lib/stat-w32.c: line 111: not properly indented
cppi: lib/stat-w32.c: line 136: not properly indented
cppi: lib/stat-w32.c: line 155: not properly indented
cppi: lib/stat-w32.c: line 168: not properly indented
cppi: lib/stat-w32.c: line 171: not properly indented
cppi: lib/stat-w32.c: line 197: not properly indented
cppi: lib/stat-w32.c: line 223: not properly indented
cppi: lib/stat-w32.c: line 252: not properly indented
cppi: lib/stat-w32.c: line 255: not properly indented
cppi: lib/stat-w32.c: line 256: not properly indented
cppi: lib/stat-w32.c: line 261: not properly indented
cppi: lib/stat-w32.c: line 369: not properly indented
cppi: lib/stat-w32.c: line 373: not properly indented
cppi: lib/stat-w32.c: line 377: not properly indented
cppi: lib/stat-w32.c: line 384: not properly indented
cppi: lib/stat-w32.c: line 386: not properly indented
cppi: lib/stat-w32.c: line 388: not properly indented
cppi: lib/stat-w32.c: line 406: not properly indented
cppi: lib/stat-w32.c: line 410: not properly indented
cppi: lib/stat-w32.c: line 414: not properly indented
cppi: lib/stat-w32.c: line 426: not properly indented
cppi: lib/stat-w32.c: line 428: not properly indented
cppi: lib/strverscmp.c: line 31: not properly formatted;
there must be exactly one SPACE character after each
#if, #elif, and #define directive
cppi: lib/strverscmp.c: line 32: not properly formatted;
there must be exactly one SPACE character after each
#if, #elif, and #define directive
cppi: lib/strverscmp.c: line 33: not properly formatted;
there must be exactly one SPACE character after each
#if, #elif, and #define directive
cppi: lib/strverscmp.c: line 34: not properly formatted;
there must be exactly one SPACE character after each
#if, #elif, and #define directive
cppi: lib/strverscmp.c: line 37: not properly formatted;
there must be exactly one SPACE character after each
#if, #elif, and #define directive
cppi: lib/strverscmp.c: line 38: not properly formatted;
there must be exactly one SPACE character after each
#if, #elif, and #define directive
cppi: lib/symlinkat.c: line 30: not properly indented
cppi: lib/symlinkat.c: line 31: not properly indented
cppi: lib/symlinkat.c: line 32: not properly indented
cppi: lib/utimens.c: line 381: not properly indented
cppi: lib/utimens.c: line 383: not properly indented
make: *** [Makefile:127: sc_cpp_indent_check] Error 123
Apparently the gnulib indentation conventions, even of the modules owned
by Jim and Eric, have deviated from the cppi conventions.
$ make sc_check_sym_list
--- /dev/fd/63 2025-05-07 10:14:42.005029939 +0200
+++ /dev/fd/62 2025-05-07 10:14:42.005029939 +0200
@@ -1,10 +1,3 @@
-TYPE_IS_INTEGER TYPE_SIGNED EXPR_SIGNED INT_PROMOTE TYPE_WIDTH
-TYPE_MINIMUM TYPE_MAXIMUM INT_BITS_STRLEN_BOUND INT_STRLEN_BOUND
-INT_BUFSIZE_BOUND INT_ADD_RANGE_OVERFLOW INT_SUBTRACT_RANGE_OVERFLOW
-INT_NEGATE_RANGE_OVERFLOW INT_MULTIPLY_RANGE_OVERFLOW
-INT_DIVIDE_RANGE_OVERFLOW INT_REMAINDER_RANGE_OVERFLOW
-INT_LEFT_SHIFT_RANGE_OVERFLOW INT_ADD_OVERFLOW INT_SUBTRACT_OVERFLOW
-INT_NEGATE_OVERFLOW INT_MULTIPLY_OVERFLOW INT_DIVIDE_OVERFLOW
-INT_REMAINDER_OVERFLOW INT_LEFT_SHIFT_OVERFLOW INT_ADD_WRAPV
-INT_SUBTRACT_WRAPV INT_MULTIPLY_WRAPV INT_ADD_OK INT_SUBTRACT_OK
-INT_MULTIPLY_OK
+$(shell f=$(gnulib_dir)/lib/intprops.h;
+ perl -lne '$(gl_extract_define_simple)' $$f | sort -u | tr '\n' ' ')
+# Remove trailing space and convert to a regular expression:
make: *** [Makefile:129: sc_check_sym_list] Error 1
top/maint.mk no longer has an explicit list of macros to check for, since
2016-12-30. Thus this rule is obsolete.
2025-05-07 Bruno Haible <br...@clisp.org>
Remove obsolete syntax-check rules.
* Makefile (sc_maint): Comment out.
(sc_cpp_indent_check, sc_check_sym_list): Remove targets.
diff --git a/Makefile b/Makefile
index 88f8cd304d..b2d0cec897 100644
--- a/Makefile
+++ b/Makefile
@@ -73,12 +73,13 @@ sc_prohibit_sc_omitted_at:
1>&2; exit 1; } || : \
else :; fi
-# Run all maint.mk syntax-check tests on gnulib's sources.
-sc_maint:
- @rm -f maint.mk; ln -s top/maint.mk maint.mk
- $(MAKE) -s srcdir=. gnulib_dir=. _build-aux=build-aux \
- -f cfg.mk -f maint.mk syntax-check
- rm -f maint.mk
+## Unmaintained. When removing this rule, also remove cfg.mk.
+## # Run all maint.mk syntax-check tests on gnulib's sources.
+## sc_maint:
+## @rm -f maint.mk; ln -s top/maint.mk maint.mk
+## $(MAKE) -s srcdir=. gnulib_dir=. _build-aux=build-aux \
+## -f cfg.mk -f maint.mk syntax-check
+## rm -f maint.mk
sc_prohibit_AC_LIBOBJ_in_m4:
url=https://lists.gnu.org/r/bug-gnulib/2011-06/msg00051.html; \
@@ -120,26 +121,6 @@ sc_pragma_columns:
exit 1; } || :; \
else :; fi
-# Verify that certain (for now, only Jim Meyering and Eric Blake's)
-# *.c files are consistently cpp indented.
-sc_cpp_indent_check:
- @./gnulib-tool --extract-filelist \
- $$(cd ./modules; grep -ilrE '(meyering|blake)' .) \
- | sort -u \
- | grep '\.c$$' \
- | grep -vE '/(stdio-(read|write)|getloadavg)\.c$$' \
- | xargs cppi -c
-
-# Ensure that the list of symbols checked for by the
-# sc_prohibit_intprops_without_use rule match those in the actual file.
-# Extract the symbols from the .h file and compare with the list of
-# symbols extracted from the rule in maint.mk.
-sc_check_sym_list:
- @i=lib/intprops.h; \
- diff -u <(perl -lne '/^# *define ([A-Z]\w+)\(/ and print $$1' $$i|fmt) \
- <(sed -n /^_intprops_name/,/^_intprops_syms_re/p top/maint.mk \
- |sed '/^_/d;s/^ //;s/ *\\$$//')
-
# List of C macros defined through AH_VERBATIM in m4/extern-inline.m4:
config_h_MACROS1 = \
