Paul Eggert wrote:
> * m4/iconv.m4 (AM_ICONV_LINK, AM_ICONV):
> Avoid whitespace at line end in C code.

This patch has two drawbacks:

  * It attempts to fix a general Autoconf problem with -Wtrailing-whitespace
    in this particular place only. The general Autoconf problem is that

      empty=
      AC_DEFINE_UNQUOTED([FOO], [$empty], [blurb])

    generates in config.h:

      #define FOO 

    Whereas
      AC_DEFINE_UNQUOTED([FOO], [], [blurb])
    generates
      #define FOO /**/
    without trailing whitespace.

  * As Collin noticed, it changes the external interface of the AM_ICONV
    macro, requiring changes outside Gnulib.

It is preferable to handle -Wtrailing-whitespace more generally.
Done as follows:






Reply via email to