> On 20. Mar 2025, at 17:23, Bruno Haible <br...@clisp.org> wrote: > > Yury V. Zaytsev wrote: >> due to AC_MSG_ERROR failing the build, Termux had to patch our build system. >> I didn't know the FIXME was there because you support Windows... Anyway, can >> AC_MSG_ERROR be removed now? > > The AC_MSG_ERROR is useful to alert us of platforms with missing support. > At this point, no known platform triggers this AC_MSG_ERROR.
As I said in my first post, I would expect `gl_MOUNTLIST` to define `gl_cv_list_mounted_fs` and let *me* decide whether to fail or not. The documentation seems to support this expectation: https://www.gnu.org/software/gnulib/MODULES.html#module=mountlist Otherwise, `gl_CONDITIONAL` doesn't seem to make sense. Now, that was an honest question. If you think you want to keep `AC_MSG_ERROR`, then maybe it makes sense to remove the FIXME and update the documentation to say that the module will fail unconditionally if the system is not supported. > On Android, within Termux, the mountlist module builds fine. Its unit test > behaves reasonably: […] > > What is the problem that you are seeing? As usual, please describe > 1. what are you attempting to do? > 2. what is the result? That's right, I didn't say I was seeing any problems. What I did was ask a question as to why you are failing unconditionally if the platform is not supported. The reason I asked is that an early version of Termux had to patch `AC_MSG_ERROR` out of our build system, which I found odd. Only then did I realize that they had no other choice until they implemented enough support to make the module work, even though *I* consider it an optional feature. So again, I went to ask why this module fails unconditionally for unsupported platforms.
