Bruno Haible <br...@clisp.org> writes:

> A nit: In an @itemize list, each paragraph has an @item line. When you
> add a paragraph, and an @item before it. When you delete a paragraph,
> delete the @item before it.
>
> But you shouldn't delete such a paragraph. Rather, move it from the
> section "Portability problems not fixed by Gnulib" to the section
> "Portability problems fixed by Gnulib". The reader wants to know what
> the portability problems are that are fixed by the module.

Oops, good catch.

Fixed with the attached patch.

Collin

>From 4beb431a3f2b425e76ea826228d1a0102fc965e3 Mon Sep 17 00:00:00 2001
From: Collin Funk <collin.fu...@gmail.com>
Date: Sat, 28 Dec 2024 17:26:28 -0800
Subject: [PATCH] doc: Fix the previous commit.

Suggested by Bruno Haible in:
<https://lists.gnu.org/archive/html/bug-gnulib/2024-12/msg00236.html>.

* doc/posix-functions/getservbyname.texi: Mention the Windows
declaration under "Portability problems fixed by Gnulib".
* doc/posix-functions/getservbyport.texi: Likewise.
---
 ChangeLog                              | 7 +++++++
 doc/posix-functions/getservbyname.texi | 5 ++++-
 doc/posix-functions/getservbyport.texi | 5 ++++-
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 4c3d2a88da..3dbab44698 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2024-12-28  Collin Funk  <collin.fu...@gmail.com>
 
+	doc: Fix the previous commit.
+	Suggested by Bruno Haible in:
+	<https://lists.gnu.org/archive/html/bug-gnulib/2024-12/msg00236.html>.
+	* doc/posix-functions/getservbyname.texi: Mention the Windows
+	declaration under "Portability problems fixed by Gnulib".
+	* doc/posix-functions/getservbyport.texi: Likewise.
+
 	doc: Mention the servent module.
 	* doc/posix-functions/getservbyname.texi: Document that the servent
 	module will provide the declarations in netdb.h.
diff --git a/doc/posix-functions/getservbyname.texi b/doc/posix-functions/getservbyname.texi
index d98a9e0a7a..2e843fee1e 100644
--- a/doc/posix-functions/getservbyname.texi
+++ b/doc/posix-functions/getservbyname.texi
@@ -8,9 +8,12 @@ @node getservbyname
 
 Portability problems fixed by Gnulib:
 @itemize
+@item
+This function is declared in @code{<winsock2.h>} instead of @code{<netdb.h>}
+on some platforms:
+mingw, MSVC 14.
 @end itemize
 
 Portability problems not fixed by Gnulib:
 @itemize
-@item
 @end itemize
diff --git a/doc/posix-functions/getservbyport.texi b/doc/posix-functions/getservbyport.texi
index 8c275fe64a..8d3a3da240 100644
--- a/doc/posix-functions/getservbyport.texi
+++ b/doc/posix-functions/getservbyport.texi
@@ -8,9 +8,12 @@ @node getservbyport
 
 Portability problems fixed by Gnulib:
 @itemize
+@item
+This function is declared in @code{<winsock2.h>} instead of @code{<netdb.h>}
+on some platforms:
+mingw, MSVC 14.
 @end itemize
 
 Portability problems not fixed by Gnulib:
 @itemize
-@item
 @end itemize
-- 
2.47.1

Reply via email to