Paul Eggert wrote:
> Thanks, my earlier patch had that limited indentation only to make its 
> diff easier to review (since it kept the existing physical indentation 
> while increasing logical indentation).

While this is a consideration in projects which review patches before
they are committed (e.g. glibc), here in most cases we review patches
that are already committed, and with 'gitk' the reviewer not only has
the option "Ignore space change", but also the option to increase the
number of context lines to 10 or 30. I couldn't do some code reviews
without 'gitk'.

Bruno




Reply via email to