Bruno Haible via Gnulib discussion list <bug-gnulib@gnu.org> writes:

> Simon Josefsson wrote:
>> I merged this now, thank you!
>
> And here's the cross-compilation handling that I promised to add.

Both this and the other one looks fine, thank you!

>  configure.ac:
>  AC_REQUIRE([gl_CRC_SLICE_BY_8])
> +CROSS_COMPILING=$cross_compiling
> +AC_SUBST([CROSS_COMPILING])
> +AC_PROG_MKDIR_P

While CROSS_COMPILING is a common variable used for this purpose, this
is bad namespace usage -- how about GL_CRC_CROSS_COMPILING,
GL_CROSS_COMPILING or GNULIB_CROSS_COMPILING instead?  Maybe this could
go into some gnulib-*.m4 file instead, it seems quite broadly useful.

Or if we believe all usages of CROSS_COMPILING in projects we care about
are all consistent with the above usage, then maybe re-using that
variable name is fine...

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to