I know you guys have other work to do, and I appreciate your work on this so far. I would like to get this merged soon if possible.
Bruno, can you please confirm whether you're happy with my implementation of the AC_ARG_ENABLE invocation? If so, I think we should be good to merge. If there's anything outstanding please let me know and I'm happy to add whatever is missing. On Mon, 28 Oct 2024 at 22:06, Sam Russell <sam.h.russ...@gmail.com> wrote: > Is there anything else we're missing on this patch? From what I can tell > the configure flag is just the standard behaviour of AC_ARG_ENABLE, so with > this setup the new slice-by-8 implementation will be enabled by default, > but maintainers have the option to disable it > > On Sun, Oct 27, 2024, 23:21 Simon Josefsson <si...@josefsson.org> wrote: > >> Thanks - I am happy with this version, or even without the user-visible >> logic too (not sure if this is something users should ever tune). My >> question about selection logic was more for maintainers rather than >> end-users. >> >> /Simon >> >> 27 okt. 2024 kl. 23:04 skrev Sam Russell <sam.h.russ...@gmail.com>: >> >> >> I had a play with autoconf (inspired heavily by m4/debug.m4), can confirm >> the behaviour works as follows: >> >> # build with slice-by-8 (default enabled) >> ./configure >> make >> gltests/bench-crc 1000000 >> real 1.714850 >> user 1.715 >> sys 0.000 >> # build without slice-by-8 >> ./configure --disable-crc-slice-by-8 >> make >> gltests/bench-crc 1000000 >> real 7.500251 >> user 7.500 >> sys 0.000 >> >> I don't know what the "serial" field is for so happy for this to be >> changed to whatever you like >> >> >> >> On Sun, 27 Oct 2024 at 16:56, Bruno Haible <br...@clisp.org> wrote: >> >>> Simon Josefsson wrote: >>> > I am not certain about the method to enable/disable the optimization, >>> > is the configure.ac variable the best method we have? >>> >>> An AC_ARG_ENABLE invocation can be added. Since Sam said that he's not >>> familiar >>> with Autoconf, it would be your turn to add it... >>> >>> Bruno >>> >>> >>> >>> <0001-crc-New-optimised-slice-by-8-implementation.patch> >> >>
