Paul Eggert wrote:
> I installed the 2nd patch as an optimization discovered after more
> testing with coreutils.
This patch causes another regression: A compilation error on macOS and
NetBSD.
On macOS (12..15):
/Users/runner/work/ci-testdir-check/ci-testdir-check/macos-compile clang
-DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -DNO_XMALLOC -DEXEEXT=\"\" -I.
-I../../gllib -I.. -DGNULIB_STRICT_CHECKING=1 -I/Users/runner/include
-I/usr/local/opt/gettext/include -I/usr/local/opt/libiconv/include -Wall
-DCONTINUE_AFTER_ASSERT -I/usr/local/include -fvisibility=hidden -g -O2 -MT
file-has-acl.o -MD -MP -MF $depbase.Tpo -c -o file-has-acl.o
../../gllib/file-has-acl.c &&\
mv -f $depbase.Tpo $depbase.Po
../../gllib/file-has-acl.c:427:21: error: use of undeclared identifier
'acl_extended_file'
? acl_extended_file
^
../../gllib/file-has-acl.c:428:21: error: use of undeclared identifier
'acl_extended_file_nofollow'
: acl_extended_file_nofollow)
^
2 errors generated.
make[4]: *** [file-has-acl.o] Error 1
On NetBSD 10:
gcc -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -DNO_XMALLOC -DEXEEXT=\"\" -I.
-I../../gllib -I.. -DGNULIB_STRICT_CHECKING=1 -I/usr/pkg/include -Wall
-DCONTINUE_AFTER_ASSERT -fvisibility=hidden -g -O2 -MT file-has-acl.o -MD -MP
-MF $depbase.Tpo -c -o file-has-acl.o ../../gllib/file-has-acl.c && mv -f
$depbase.Tpo $depbase.Po
../../gllib/file-has-acl.c: In function ‘file_has_aclinfo’:
../../gllib/file-has-acl.c:427:21: error: ‘acl_extended_file’ undeclared (first
use in this function); did you mean ‘acl_delete_def_file’?
427 | ? acl_extended_file
| ^~~~~~~~~~~~~~~~~
| acl_delete_def_file
../../gllib/file-has-acl.c:427:21: note: each undeclared identifier is reported
only once for each function it appears in
../../gllib/file-has-acl.c:428:21: error: ‘acl_extended_file_nofollow’
undeclared (first use in this function); did you mean ‘acl_extended_file’?
428 | : acl_extended_file_nofollow)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| acl_extended_file
*** Error code 1
Bruno
