Hi Collin, > Now that sys/un.h might be replaced by Gnulib we have to keep in mind > the #include <...> vs. #include "..." issue.
Yes, good point. > I also noticed some other files in lib/*.in.h were missing from the > lists so I added them too. This is unnecessary. As noted in <https://lists.gnu.org/archive/html/bug-gnulib/2024-02/msg00146.html> only those header files are needed that make use of #include_next. Do a 'grep @INCLUDE_NEXT@ lib/*.in.h'. > Re-sort list. Your sort order is not appropriate. It sorts in the following order: sysexits.h sys/file.h system.h sys/un.h which is weird. It is better to choose a sort order that keeps all sys/* together. Which is what you happen to get in the "C" locale. > First patch is adding them to the docs and second is adding them to > maint.mk. Separate patches since I'm not sure if docs or maint.mk are > back ported to stable branches. So it seemed less problematic that way. Yes, that's OK. Two changes can be logically related. If the changes don't imply each other, i.e. if they _can_ be used separately, it's reasonable to make them separate commits. (Unless it's clearly too much overhead w.r.t. the ChangeLog. For example, if one fixes the same typo in 3 different files, we will usually create a single commit.) Bruno
