On mingw-w64 5.0, I see a MT unit test go havoc when given enough time:
LC_ALL=French_France.1252 ./test-c-strtof-mt.exe 600 => OK
LC_ALL=French_France.1252 ./test-c-strtod-mt.exe 600 => OK
LC_ALL=French_France.1252 ./test-c-strtold-mt.exe 600 => Segmentation fault or
Windows bluescreen
The cause is a malloc() without a free(), at *every* invocation
of strtold(), and without checking the result of malloc() against NULL.
And when the mingw people got notified about the memory leak,
the replaced the bug with another bug.
There is no problem on MSVC, because on MSVC 'long double' is the same as
'double':
LC_ALL=French_France.1252 ./test-c-strtof-mt.exe 600 => OK
LC_ALL=French_France.65001 ./test-c-strtof-mt.exe 600 => OK
LC_ALL=French_France.1252 ./test-c-strtod-mt.exe 600 => OK
LC_ALL=French_France.65001 ./test-c-strtod-mt.exe 600 => OK
LC_ALL=French_France.1252 ./test-c-strtold-mt.exe 600 => OK
LC_ALL=French_France.65001 ./test-c-strtold-mt.exe 600 => OK
These two patches provide workarounds.
2024-07-14 Bruno Haible <br...@clisp.org>
Activate strtold workarounds.
* modules/c-strtold-tests (Depends-on): Add strtold.
* modules/ldtoastr (Depends-on): Add strtold.
2024-07-14 Bruno Haible <br...@clisp.org>
strtold: Work around major mingw bugs.
* lib/strtod.c (HAVE_UNDERLYING_STRTOD) [USE_LONG_DOUBLE]: Set to 0 on
mingw versions before 10.0.
* doc/posix-functions/strtold.texi: Mention the mingw bugs.
>From 68432dda5e8ec389bd929057423af32c86827822 Mon Sep 17 00:00:00 2001
From: Bruno Haible <br...@clisp.org>
Date: Sun, 14 Jul 2024 18:38:16 +0200
Subject: [PATCH 1/2] strtold: Work around major mingw bugs.
* lib/strtod.c (HAVE_UNDERLYING_STRTOD) [USE_LONG_DOUBLE]: Set to 0 on
mingw versions before 10.0.
* doc/posix-functions/strtold.texi: Mention the mingw bugs.
---
ChangeLog | 7 +++++++
doc/posix-functions/strtold.texi | 4 ++++
lib/strtod.c | 7 +++++++
3 files changed, 18 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 56c0253f7a..44977a92fa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2024-07-14 Bruno Haible <br...@clisp.org>
+
+ strtold: Work around major mingw bugs.
+ * lib/strtod.c (HAVE_UNDERLYING_STRTOD) [USE_LONG_DOUBLE]: Set to 0 on
+ mingw versions before 10.0.
+ * doc/posix-functions/strtold.texi: Mention the mingw bugs.
+
2024-07-13 Collin Funk <collin.fu...@gmail.com>
useless-if-before-free: Fix copyright year in --version output.
diff --git a/doc/posix-functions/strtold.texi b/doc/posix-functions/strtold.texi
index 3fc1136ecb..5dbe158464 100644
--- a/doc/posix-functions/strtold.texi
+++ b/doc/posix-functions/strtold.texi
@@ -53,6 +53,10 @@
This function fails to set @code{errno} upon underflow on some platforms:
@c https://cygwin.com/ml/cygwin/2019-12/msg00072.html
Cygwin 2.9.
+
+@item
+This function leaks memory on mingw 5.0
+and allocates an unbounded amount of stack on mingw 9.0.
@end itemize
Portability problems not fixed by Gnulib:
diff --git a/lib/strtod.c b/lib/strtod.c
index a545be09a4..e218a46f71 100644
--- a/lib/strtod.c
+++ b/lib/strtod.c
@@ -60,6 +60,13 @@
# elif STRTOLD_HAS_UNDERFLOW_BUG
/* strtold would not set errno=ERANGE upon underflow. */
# define HAVE_UNDERLYING_STRTOD 0
+# elif defined __MINGW32__ && __MINGW64_VERSION_MAJOR < 10
+ /* strtold is broken in mingw versions before 10.0:
+ - Up to mingw 5.0.x, it leaks memory at every invocation.
+ - Up to mingw 9.0.x, it allocates an unbounded amount of stack.
+ See <https://github.com/mingw-w64/mingw-w64/commit/450309b97b2e839ea02887dfaf0f1d10fb5d40cc>
+ and <https://github.com/mingw-w64/mingw-w64/commit/73806c0709b7e6c0f6587f11a955743670e85470>. */
+# define HAVE_UNDERLYING_STRTOD 0
# else
# define HAVE_UNDERLYING_STRTOD HAVE_STRTOLD
# endif
--
2.34.1
>From 51bcbc95b5955ca8a6c127fe2117647fd0c6a914 Mon Sep 17 00:00:00 2001
From: Bruno Haible <br...@clisp.org>
Date: Sun, 14 Jul 2024 18:39:29 +0200
Subject: [PATCH 2/2] Activate strtold workarounds.
* modules/c-strtold-tests (Depends-on): Add strtold.
* modules/ldtoastr (Depends-on): Add strtold.
---
ChangeLog | 6 ++++++
modules/c-strtold-tests | 1 +
modules/ldtoastr | 1 +
3 files changed, 8 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 44977a92fa..6bca856db2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-07-14 Bruno Haible <br...@clisp.org>
+
+ Activate strtold workarounds.
+ * modules/c-strtold-tests (Depends-on): Add strtold.
+ * modules/ldtoastr (Depends-on): Add strtold.
+
2024-07-14 Bruno Haible <br...@clisp.org>
strtold: Work around major mingw bugs.
diff --git a/modules/c-strtold-tests b/modules/c-strtold-tests
index 7686da9755..fb1b6a80e0 100644
--- a/modules/c-strtold-tests
+++ b/modules/c-strtold-tests
@@ -17,6 +17,7 @@ signbit
setlocale
thread
nanosleep
+strtold
configure.ac:
gt_LOCALE_FR
diff --git a/modules/ldtoastr b/modules/ldtoastr
index 40d69f3d6c..15d39162cd 100644
--- a/modules/ldtoastr
+++ b/modules/ldtoastr
@@ -9,6 +9,7 @@ lib/ldtoastr.c
Depends-on:
extensions
intprops
+strtold
configure.ac:
--
2.34.1
