Hi Collin, > Can you check the attached patch? I think that it should work or > at least be in the correct direction...
In the endian.in.h file: The comments on the 3 last lines are not consistent with the '#endif' scopes. In the Makefile.am snippet: A few lines are indented with spaces, not with a tab. It would not cause an error here, since these are only continuation lines, I think. But nevertheless better be consistent with how other modules do it. Other than that, it looks correct. > I've split the configure checks into one checking for uint16_t, etc. > and the other checking for macros/function definitions. The reason for > this is that glibc defines macros/functions properly, so we just need > the stdint.h types. I assume this might occur on other systems but > that is just a guess. Yes, that's the right way to do this. > For other platforms the configure checks might fail because > function-like macros are used. In that case we can include endian.h > from the system and #undef the macros before our own definition. OK. > Also, double checking that I understand the #include_next idioms would > be appreciated. You have applied these idioms correctly, yes. > Feel free to push this patch if it is okay. I don't want this module > to mess with your CI jobs. Thanks for the consideration. But I don't think it will mess with my CI runs, because they run on newer glibc versions. Bruno
