Hi Collin, > Should all glibc functions have a signature check? For these ones I > was conflicted on adding them since they are not standardized, but > provided on BSD and glibc.
If Gnulib is not the only implementation, then yes it is advisable to have the signature check. For example, if on some platform getusershell were to return 'const char *' instead of 'char *', it would be a portability problem because code such as char *s = getusershell (); would be invalid. We want to know about such portability problems. Since it is too time-consuming (and also not future-proof) to manually check the unistd.h file of all platforms, the better way is to check the signature in the unit test and arrange to run the unit tests on as many platforms as possible. Bruno
