Hi Collin,
> > The 'libtests' value read from the config in self.emitter is
> > incorrect.
>
> This patch seems to support what I was saying here.
>
> diff --git a/pygnulib/GLTestDir.py b/pygnulib/GLTestDir.py
> index 002eb30267..11b067e085 100644
> --- a/pygnulib/GLTestDir.py
> +++ b/pygnulib/GLTestDir.py
> @@ -244,8 +244,7 @@ def execute(self) -> None:
> if file.startswith('lib/'):
> libtests = True
> break
> - if libtests:
> - self.config.setLibtests(True)
> + self.emitter.config.setLibtests(libtests)
>
> if single_configure:
> # Add the dummy module to the main module list if needed.
Thanks! OK to push in 1 or 2 days.
> Though, the correct way to fix this would be making instance variables
> local when they are only used in one function.
I agree that this kind of doing side effects on a GLConfig object that
is already held by another object is not super maintainable.
However, this is not the only call to setLibTests. There is another one
at GLTestDir.py:392. And there is a call to setAuxDir in GLTestDir.py:401.
It seems that a conversion to use instance variables or local variables
would be quite intrusive. I'm not sure this refactoring would be worth it.
Bruno
