On 4/25/24 5:14 PM, Bruno Haible wrote: > Yes, the other heuristic is that when many functions operate on the > same object, like methods in class do, the pointer to that object > is often passed first. And, as you noticed, the two heuristics collide... > > Here, I would not think of 'rewrite_file_name' as a method pertaining > to the class GLConfig. Rather, GLConfig is just one of the parameters.
Yeah, that makes sense. I'll keep that in mind. > Perfect. OK to push. Done. > Correct. Feel free to add tests for --copy-file, if you like. > I didn't spend time on it, since --copy-file is simple enough. Sure, I can have a look at adding some. I see it is part of the Gnulib Savannah group so I can commit changes there. I assume same rules go there too, always send patches for review? > Ah, that's because exitfail.h was modified in Gnulib a few days ago. > Will adapt the override in gettext. Thanks for the notice. Thanks! I see now that the #ifdef __cplusplus change messed up the patch. Collin
