Re: gnulib-tool.py: Prefer 'list.append(item)' over 'list += [item]'.

[Collin Funk]

Hi Bruno,

On 4/8/24 6:28 PM, Bruno Haible wrote:
> What about GLEmiter.py line 468?

Oops, good catch. I must have been focused on not messing with line
460:

    emit += "# But here it has a '-gnulib' suffix.\n"

But forgot to come back to it.

You can apply the attached patch or fix it without a ChangeLog entry.
Not sure which is preferred.

Collin
From 24c8df1ac3309c6966d1283a8f4e873a7e44f181 Mon Sep 17 00:00:00 2001
From: Collin Funk <collin.fu...@gmail.com>
Date: Mon, 8 Apr 2024 18:34:16 -0700
Subject: [PATCH] gnulib-tool.py: Use single-quotes for strings, part 2.

* pygnulib/GLEmiter.py (GLEmiter.po_Makevars): Change a double-quoted
string to single-quotes missed by the previous commit.
---
 ChangeLog            | 6 ++++++
 pygnulib/GLEmiter.py | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index fe6a8974b6..6a3e1996cf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-04-08  Collin Funk  <collin.fu...@gmail.com>
+
+	gnulib-tool.py: Use single-quotes for strings, part 2.
+	* pygnulib/GLEmiter.py (GLEmiter.po_Makevars): Change a double-quoted
+	string to single-quotes missed by the previous commit.
+
 2024-04-08  Collin Funk  <collin.fu...@gmail.com>
 
 	gnulib-tool.py: Use single-quotes for strings.
diff --git a/pygnulib/GLEmiter.py b/pygnulib/GLEmiter.py
index 963d3ac3ad..e6143645be 100644
--- a/pygnulib/GLEmiter.py
+++ b/pygnulib/GLEmiter.py
@@ -465,7 +465,7 @@ class GLEmiter:
         podomain = self.config['podomain']
         emit = ''
         emit += '## DO NOT EDIT! GENERATED AUTOMATICALLY!\n'
-        emit += "%s\n" % self.copyright_notice()
+        emit += '%s\n' % self.copyright_notice()
         emit += '# Usually the message domain is the same as the package name.\n'
         emit += "# But here it has a '-gnulib' suffix.\n"
         emit += 'DOMAIN = %s-gnulib\n\n' % podomain
-- 
2.44.0