Hello Collin, Back to our usual business.
> This small patch fixes this diff in the import tests: > > $ cat ../output.txt > $ diff -u ./test-oath-toolkit-1.result/gl/m4/gnulib-cache.m4 > tmp27490-result/gl/m4/gnulib-cache.m4 > --- ./test-oath-toolkit-1.result/gl/m4/gnulib-cache.m4 2024-03-29 > 02:47:03.843697386 -0700 > +++ tmp27490-result/gl/m4/gnulib-cache.m4 2024-03-29 20:02:25.589459017 > -0700 > @@ -37,7 +37,6 @@ > # --no-conditional-dependencies \ > # --no-libtool \ > # --macro-prefix=gl \ > -# --no-vc-files \ > # autobuild \ > # git-version-gen \ > # gitlog-to-changelog \ > @@ -64,4 +63,3 @@ > gl_MACRO_PREFIX([gl]) > gl_PO_DOMAIN([]) > gl_WITNESS_C_MACRO([]) > -gl_VC_FILES([false]) Thanks. Applied. > How about we remove that cleaner function and simply make the regular > expression more strict? It should make it behave more similar to > gnulib-tool.sh anyways. Something like this for an (untested) idea: I don't like the 'cleaner' function either, because it converts 'false' -> False regardless of the desired data type. Once the test suite entirely passes, will be the time to revisit this 'cleaner' function. Your approach with the regex can be part of the solution. Bruno
