Eric Gallager wrote: > wouldn't it be good to add some additional tests anyways?
I'm satisfied with testing that the invocations of this macro in GNU gettext produce, in 'configure', exactly the expansion that I would expect. If you want to contribute a unit test for it, feel free to do so. > Like, why isn't the build-to-host.m4 macro file its own module? > Specifically, what I'm thinking of doing would be something like this: > > diff --git a/modules/build-to-host b/modules/build-to-host > new file mode 100644 > index 0000000000..0c4482ae21 > --- /dev/null > +++ b/modules/build-to-host > @@ -0,0 +1,22 @@ > +Description: > + > +Files: > +m4/build-to-host.m4 > + > +Depends-on: > + > +configure.ac-early: > +gl_BUILD_TO_HOST_INIT > + > +configure.ac: > +gl_BUILD_TO_HOST([builddir]) > + > +Makefile.am: > + > +Include: > + > +License: > +GPL > + > +Maintainer: > +all Yes, for adding a unit test module, adding a module file like the one you showed is the first step. Note: The configure.ac-early section is not needed here, since gl_BUILD_TO_HOST_INIT is already AC_REQUIREd. Bruno
