Hi Collin,

> While running that I noticed this in gltests/Makefile.am:
> 
> -LDADD = ../gllib/libgnu.a libtests.a ../gllib/libgnu.a
> +LDADD = ../gllib/libgnu.a
> 
> I've copied the logic for this from gnulib-tool and the attached patch
> fixes this.

Thanks, applied. (With an extra newline, just to make it clear that the
%s/%s/%s.%s arguments are the same in all three cases. Could be simplified
in the future, but that's not a priority now.)

> Also I've just noticed that GLImport has an exit() call that prevents
> the advice for headers and such from being printed [1]. It is also
> documented in gnulib-tool.py.TODO [2]. Is there a reason for this? The
> git history doesn't seem to say much and it worked fine when I tried
> it _once_. Just seems sort of strange LOL

It's a strange way to disable Python code that is not ready yet :-)

It is a goal to have gnulib-tool.py not only produce the same files, but also
the same stdout output as gnulib-tool. (Whereas the stderr output can be
reasonably different, depending on error situations.) The 'exit()' invocation
only means that neither Dmitry nor I have tested this code in a long long time.

Bruno




Reply via email to