Jim Meyering <j...@meyering.net> writes: > Thank you both. I've just pushed an improvement. > The new version runs grep only once rather than many times, and seems simpler.
Thanks. This one seems much better. It also returns 1 if an invalid quoted header is found which I forgot to do. This Makefile would probably be good view for me. :) I feel like this rule might cause some false positives for some projects in a few rare cases. Files in the namespace std*.h and sys/*.h probably shouldn't be used (not sure if they are explicitly reserved). However, it might be possible that a project uses it's own "error.h" or "search.h", for example, unrelated to gnulib. Would it make sense to add an exclude regexp to cfg.mk or make a note about reserved header names in the documentation?
