Hi, Nick Bowler wrote: > The case pattern which matches solaris2.[1-9] etc. is not fully > quoted, so the brackets get eaten by m4 and don't actually make > it into the resulting configure script, giving just: > > case "$host_os" in > solaris | solaris2.1-9 | solaris2.1-9.* | hpux*) > > which is obviously not correct.
Oh, indeed! Thanks for the observation and the fix. I have applied it in your name. (The "tiny change" marker in the ChangeLog merely means that the change is small enough that I could apply it without asking you for a copyright assignment. Cf. https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html .) > * m4/threadlib.m4 (gl_STDTHREADLIB_BODY): Allow case patterns to > survive m4 processing by using changequote. The change was in gl_PTHREADLIB_BODY, not in gl_STDTHREADLIB_BODY. But anyway, thanks for providing the change description in the first place. Bruno 2023-01-25 Nick Bowler <nbow...@draconx.ca> (tiny change) threadlib: Fix support for Solaris 9 and older. * m4/threadlib.m4 (gl_PTHREADLIB_BODY): Allow case patterns to survive m4 processing by using changequote. diff --git a/m4/threadlib.m4 b/m4/threadlib.m4 index 48ced460b3..7202b9528d 100644 --- a/m4/threadlib.m4 +++ b/m4/threadlib.m4 @@ -1,4 +1,4 @@ -# threadlib.m4 serial 34 +# threadlib.m4 serial 35 dnl Copyright (C) 2005-2023 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -261,7 +261,9 @@ AC_DEFUN([gl_PTHREADLIB_BODY], # On Solaris 10 or newer, this test is no longer needed, because # libc contains the fully functional pthread functions. case "$host_os" in +changequote(,)dnl solaris | solaris2.[1-9] | solaris2.[1-9].* | hpux*) +changequote([,])dnl AC_DEFINE([PTHREAD_IN_USE_DETECTION_HARD], [1], [Define if the pthread_in_use() detection is hard.]) esac
