Paul Eggert wrote:
> I installed into Gnulib the stdbool patches ...
The changes to the files
lib/unicase.in.h
lib/unictype.in.h
lib/unigbrk.in.h
lib/unistr.in.h
are not good, because these files ultimately get installed as public header
files:
1. They get copied to libunistring, with <stdbool.h> replaced with
<unistring/stdbool.h>.
2. They get installed by "make install".
3. The user uses them with a compiler that maybe is only C99 compliant.
I did not see this during the review. But the continuous integration caught it.
2022-09-18 Bruno Haible <br...@clisp.org>
uni{case,ctype,gbrk,str}/base: Fix installed .h file (regr. 2022-09-10).
* lib/unicase.in.h: Do include <stdbool.h>.
* lib/unictype.in.h: Likewise.
* lib/unigbrk.in.h: Likewise.
* lib/unistr.in.h: Likewise.
diff --git a/lib/unicase.in.h b/lib/unicase.in.h
index 5317cd3dd8..9bcc79edd8 100644
--- a/lib/unicase.in.h
+++ b/lib/unicase.in.h
@@ -27,6 +27,9 @@
#include "unitypes.h"
+/* Get bool. */
+#include <stdbool.h>
+
/* Get size_t. */
#include <stddef.h>
diff --git a/lib/unictype.in.h b/lib/unictype.in.h
index de6a191d87..2f0efefca8 100644
--- a/lib/unictype.in.h
+++ b/lib/unictype.in.h
@@ -19,6 +19,9 @@
#include "unitypes.h"
+/* Get bool. */
+#include <stdbool.h>
+
/* Get size_t. */
#include <stddef.h>
diff --git a/lib/unigbrk.in.h b/lib/unigbrk.in.h
index 7fbc2a0d57..f1b60e17b9 100644
--- a/lib/unigbrk.in.h
+++ b/lib/unigbrk.in.h
@@ -26,6 +26,9 @@
#ifndef _UNIGBRK_H
#define _UNIGBRK_H
+/* Get bool. */
+#include <stdbool.h>
+
/* Get size_t. */
#include <stddef.h>
diff --git a/lib/unistr.in.h b/lib/unistr.in.h
index 40c7929575..4d48751558 100644
--- a/lib/unistr.in.h
+++ b/lib/unistr.in.h
@@ -19,6 +19,9 @@
#include "unitypes.h"
+/* Get bool. */
+#include <stdbool.h>
+
/* Get size_t, ptrdiff_t. */
#include <stddef.h>
