Re: [PATCH 1/5] posix: Sync regex code with gnulib

[Adhemerval Zanella]

On 19/01/2021 14:16, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> On 19/01/2021 13:52, Florian Weimer wrote:
>>> * Adhemerval Zanella via Libc-alpha:
>>>
>>>> Paul, this seemed to a common pattern scatter on multiple file in gnulib.
>>>> Wouldn't be better to consolidate it on cdefs.h?
>>>
>>> gnulib shouldn't be using cdefs.h on glibc systems, so I think a
>>> separate header would be needed.
>>
>> What is the problem of using cdefs.h for internal implementation? 
> 
> Isn't regex_internal.h sync'ed with gnulib?

Yes, and gnulib also has an internal cdefs (which we should sync btw).