On 8/4/20 9:58 AM, Zack Weinberg wrote:
I just pushed a commit that partially reverts a `make fetch'.Partially revert e54e3f90: restore use of $(MAKE) in error message. In commit 14d58bfd, the error message printed by the ‘abort-due-to-no-makefile’ rule in GNUmakefile was changed to refer to the value of ‘$(MAKE)’ instead of a literal ‘make’. A subsequent ‘make fetch’ (e54e3f90) clobbered this. Put it back. Clearly we need to send the change to this error message upstream, but I don't know who the upstream for this file is.
GNUmakefile comes from gnulib (the gnumakefile module). It is one of the few files that has to be checked in to git rather than populated after bootstrap; which means that every time you update to a newer version of gnulib that happens to modify the file, it results in another checkin of GNUmakefile in autoconf. That's what 'make fetch' is intended to do. So, if you want a change to stick in that file, update the gnulib version first, then update autoconf to the newer version of gnulib containing that fix.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
