Bruno Haible <br...@clisp.org> writes: > The first one is nearly perfect. Only the NEWS entry should go into section > "User visible incompatible changes", not into section "Important general > notes". > > The second one: > - In fread_file, around line 100, you use a realloc workaround that appears > to be not as reliable as the malloc+free based workaround around line 135. > - In read_file, please don't use tabs for indentation. We've switched to > spaces-only indentation long ago. > > Once this is fixed, please push.
Both has been fixed and pushed. Thank you for the review! Regards, -- Daiki Ueno
